From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddOPV-0007CA-Vz for guix-patches@gnu.org; Thu, 03 Aug 2017 18:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddOPS-0000iZ-Uv for guix-patches@gnu.org; Thu, 03 Aug 2017 18:16:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddOPS-0000hC-KN for guix-patches@gnu.org; Thu, 03 Aug 2017 18:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ddOPS-0002ul-8z for guix-patches@gnu.org; Thu, 03 Aug 2017 18:16:02 -0400 Subject: [bug#27938] [PATCH] gnu: git: Enable tests. Resent-Message-ID: Date: Thu, 3 Aug 2017 18:15:34 -0400 From: Leo Famulari Message-ID: <20170803221534.GA2421@jasmine.lan> References: <20170803210730.1122-1-mbakke@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <20170803210730.1122-1-mbakke@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 27938@debbugs.gnu.org --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 03, 2017 at 11:07:30PM +0200, Marius Bakke wrote: > * gnu/packages/version-control.scm (git)[arguments]: Remove #:tests?. Add > 'patch-tests' phase. Wow, awesome! LGTM. > + ;; Un-do shebang patching here to prevent checksum mismatch. > + (substitute* '("t/t4034/perl/pre" "t/t4034/perl/post") > + (("^#!.*/bin/perl") "#!/usr/bin/perl")) I've been thinking, we should have a way to pass a list of directories or files to exclude from the shebang patcher. We have a few packages that include files where patching the shebang is the wrong thing to do. For example, the Git example hook scripts. --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmDoIYACgkQJkb6MLrK fwibwxAA4/7fPPlkFaVrjew6fRb6QAy/iFNhwHXrlD/CCbjAGctQb6vlExRZDwqh 6enI4XMWZ4Yz+TupDmny1uIG5yPzKhy4Zw3G5vgkIuksq3w/YvK8ueSnAxt8yDws 470AlPiuonysbTETpuNh7adca9GE4hnG2WLw0iF5cbY8Izqajr+XUZlbt8wG94El gjGwBEvQLOdA2tNhm81I7KpXhN+IyTfx6Um8NusnVXXu0SXz2mEpCl78RZAowKBR otCdYUjKbXWZ0RbSTboT9XtLkyE+YsdhwQQz7GVmc/ko3ZzILNXsZgra72lAN46F u2PxmWRNUTNBlkaRMCdTsT2rFvsLWVRVd7aDC7pwkgpKrJSaBqMl49pHSZHoGntm 4LTdae7P/rzpJDj+eRSVqO+IGA69NoV8yt4kKO7z2HcmR7a1zE3i3ilNJiao3iQV Vj7IrhUZFxwY0KqxytZe+zRaJ58/P1s/VRwN4o9ghyqim1sQQSutdo38nev7fbVB HWiIDVSOKs3erY0fFP4kRLJGkqmkd7Kd9o/Uya/p9/tzzHm393bJMnyRRfRget/z bCyA86NF1vY/ThHeMWQ6rEl3E0MGfPwhjgAkVvkIo4DG9wwG66FfCQtdXJEUygs8 yWvIaW0yVlEvbd1wArcSCgPHNGlFR5PBZLiP21CT/rba1YvONE4= =a4Bb -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--