From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dczap-0001mK-48 for guix-patches@gnu.org; Wed, 02 Aug 2017 15:46:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dczak-0000If-UW for guix-patches@gnu.org; Wed, 02 Aug 2017 15:46:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dczak-0000Ia-RI for guix-patches@gnu.org; Wed, 02 Aug 2017 15:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dczak-0007sC-Hm for guix-patches@gnu.org; Wed, 02 Aug 2017 15:46:02 -0400 Subject: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase. Resent-Message-ID: Date: Wed, 2 Aug 2017 15:45:15 -0400 From: Leo Famulari Message-ID: <20170802194515.GC13105@jasmine.lan> References: <20170801072153.19077-1-kei@openmailbox.org> <20170801072153.19077-2-kei@openmailbox.org> <87k22lwys2.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline In-Reply-To: <87k22lwys2.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: Kei Kebreau , 27898@debbugs.gnu.org --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 02, 2017 at 09:33:01PM +0200, Marius Bakke wrote: > Kei Kebreau writes: [... move autoconf phases ...] > Phew! This too will cause a lot of rebuilds, but I guess we could put it > on 'staging'. It would have to be committed just before starting it to > reduce the amount of merge conflicts. Agreed > That said, I'm not sure how necessary this change is, but I don't have a > strong argument against it. Other opinions welcome! I guess there is a correct ordering and an incorrect ordering, depending on whether or not these phases should happen before or after the shebang patching phases. Does it work if it happens before the shebangs are patched? > Maybe we could add an '#:autoreconf?' parameter to gnu-build-system, > which runs `autoreconf -vif` in a phase and automatically pulls in > automake and autoconf (and probably also libtool). Thoughts? Interesting! --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmCK8sACgkQJkb6MLrK fwihpg//dTXp/80wCpsaM3gjZ39Ak+rFPIKyPe0eC5DhhrH64/Q9pdpfngS6y9Xw bNPR1+vEGmK+NAE0TQb3g4cWfntdi1iTnucPJs1kzZ8YwVG+vb1+BvOLfol+QeVg wtATnNbof1gXL3DsadCp52SYPQBniJSwLEX7+er+u1UpyamZBQG1Ez65wN4fDZmA k2XaXcQ9FB/ZuTJ0HvbqbmUujJ2MBLAOiozShUsCCysjcAJ2eW+dAc9j+2mFlaLz 7HKgHoogqYVXC/EcrH7JMYP7PqYpw3FARY9nJcGhwNiH3tYAKzyG2hwgcd9CgU3T YE7GrHy844dRFOHqyWiYey6DcQO9iupfW1s88hs/0Df03pqMhQILC48drPZCz+m8 rtLHYO3frwCnmRT5K3QZE78lJvqtmsw7UMUBAZnpeuBiGUgLG4AqLVIfTIf08Mbl tKDz6hphaMSe2mIeDJ8JB1dMyhF44L6n08ObmSlGVRDLnuDyCSKjDES8gFq9MCJw IbTY2tmQJY2MRJX0vqTzcmbx+fezG0S1p12jne2LSccUEdnqBr6Qap5l1P9zAXXD oSml4jP72v+4E9MUbU4smk1VsdosddapeiwMbra+yqBfXaOYNtMzDxIm4mXAUoYG pY1Z9BFWjkSTT4c4FZ9QspuZPNO1bCiv5M79GbPFp/6UKxfk/NE= =w0hW -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--