From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbjMT-0004oz-VY for guix-patches@gnu.org; Sun, 30 Jul 2017 04:14:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbjMQ-00063T-QW for guix-patches@gnu.org; Sun, 30 Jul 2017 04:14:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbjMQ-00063K-NI for guix-patches@gnu.org; Sun, 30 Jul 2017 04:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbjMQ-0001xK-BG for guix-patches@gnu.org; Sun, 30 Jul 2017 04:14:02 -0400 Subject: bug#27853: [PATCH 2/2] services: Add memcached. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sun, 30 Jul 2017 09:13:46 +0100 From: Christopher Baines Message-ID: <20170730091346.34fa067d@cbaines.net> In-Reply-To: <87vambgfg4.fsf@gnu.org> References: <20170729163623.13531-1-mail@cbaines.net> <20170729163623.13531-2-mail@cbaines.net> <87vambgfg4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/PozA6bfkSmvxVoxLGKetDei"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27853-done@debbugs.gnu.org --Sig_/PozA6bfkSmvxVoxLGKetDei Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 29 Jul 2017 22:23:39 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > * gnu/services/databases.scm (memcached-service-type, > > %memcached-accounts): New variables. > > (): New record type. > > (memcached-service-type): New procedures. > > * gnu/tests/databases.scm: New file. > > * doc/guix.texi (Database Services): Document the new memcached > > service. > > * gnu/local.mk (GNU_SYSTEM_MODULES): Add entry for > > tests/memcached.scm. =20 >=20 > [...] >=20 > > +@defvr {Scheme Variable} memcached-service-type > > +This is the service type for the @uref{https://memcached.org/, > > Memcached} +service, which provides a distributed in memory cache. > > The value for the service type is a @code{memcached-configuration} > > object. =20 >=20 > Please wrap lines to 80 chars and leave two spaces after an > end-of-sentence period. :-) >=20 > > +@item @code{interfaces} (default: @code{'("0.0.0.0")}) =20 >=20 > If that=E2=80=99s what upstream does, fine with me. >=20 > LGTM, thanks! I've fixed the formatting in the docs, fixed one mistake in the commit message and pushed. Thanks for your review :) --Sig_/PozA6bfkSmvxVoxLGKetDei Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAll9lTpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdFZxAAtX8dk+S86G1y6g691R+SgIdT27srSDOTcnzc3hzTr3DcyoVeGf/LL9Wk unpFiA9au/c6uVkkfNMlJU9mJJiK6Q90I7RlIYoN8/R6ic3jN0LtVPLmMr29JvfQ khZe4l/+CxKKowemtXnXhyP4G3OHmHszRx2TCz34Zt4+LA3D5Xww1GhurNEZSURU aJCzszRXul68Us5kjGZ9sTGZEr38P67xIpz+OONVCLRjyPFKoB8ik0Yl44D1bmeq 0hE+ccik5F+ezdIlt/28V1sNZK5D7Yg+xJIVBN7ewJig+7yaoFDokssO+bv3KDDw NyMlms0fGTKdf2rlfN3pOpfS0dRdObghAm5AjRI8g8DQS1zQRVUtFxRgNwmKlnz+ 4Gwl+e33E8g9cmasQ8lAX5lVTUKovXGAHSJY3cTgPgJOZZcc6tPP3g/jK1+uSwly rSUWJfIy9iMbfOGdHsBJXSi5Y/CRs76GjEAjYHmqnUTejnH9zDdsnxqgBc/307z0 WoLNeTedWiPE8W6hp/CB3JWZCgNxYqmjFZxhRz3leCodVePxwkxxZZQT3RV9fc0x ylKX2MFO5puhvJFc1H0hYrscgtrO1WRN62f026jikrdLkV/RC6jYeBV6WHH3CE5o qwgWXzkEB9tba0yrLTs8SfnF2ZoKyI75MaqhcDtk1biEMXyrLxk= =NbY/ -----END PGP SIGNATURE----- --Sig_/PozA6bfkSmvxVoxLGKetDei--