From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27853-done@debbugs.gnu.org
Subject: bug#27853: [PATCH 2/2] services: Add memcached.
Date: Sun, 30 Jul 2017 09:13:46 +0100 [thread overview]
Message-ID: <20170730091346.34fa067d@cbaines.net> (raw)
In-Reply-To: <87vambgfg4.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Sat, 29 Jul 2017 22:23:39 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Christopher Baines <mail@cbaines.net> skribis:
>
> > * gnu/services/databases.scm (memcached-service-type,
> > %memcached-accounts): New variables.
> > (<memcached-configuration>): New record type.
> > (memcached-service-type): New procedures.
> > * gnu/tests/databases.scm: New file.
> > * doc/guix.texi (Database Services): Document the new memcached
> > service.
> > * gnu/local.mk (GNU_SYSTEM_MODULES): Add entry for
> > tests/memcached.scm.
>
> [...]
>
> > +@defvr {Scheme Variable} memcached-service-type
> > +This is the service type for the @uref{https://memcached.org/,
> > Memcached} +service, which provides a distributed in memory cache.
> > The value for the service type is a @code{memcached-configuration}
> > object.
>
> Please wrap lines to 80 chars and leave two spaces after an
> end-of-sentence period. :-)
>
> > +@item @code{interfaces} (default: @code{'("0.0.0.0")})
>
> If that’s what upstream does, fine with me.
>
> LGTM, thanks!
I've fixed the formatting in the docs, fixed one mistake in the commit
message and pushed. Thanks for your review :)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-07-30 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 16:45 [bug#27853] [PATCH] Add memcached package, service and system test Christopher Baines
2017-07-27 16:49 ` [bug#27853] [PATCH 1/2] gnu: Add memcached Christopher Baines
2017-07-27 16:49 ` [bug#27853] [PATCH 2/2] services: " Christopher Baines
2017-07-28 19:46 ` Ludovic Courtès
2017-07-29 16:35 ` Christopher Baines
2017-07-28 19:41 ` [bug#27853] [PATCH 1/2] gnu: " Ludovic Courtès
2017-07-29 11:37 ` Marius Bakke
2017-07-29 16:24 ` Christopher Baines
2017-07-29 16:36 ` Christopher Baines
2017-07-29 16:36 ` [bug#27853] [PATCH 2/2] services: " Christopher Baines
2017-07-29 20:23 ` Ludovic Courtès
2017-07-30 8:13 ` Christopher Baines [this message]
2017-07-29 20:22 ` [bug#27853] [PATCH 1/2] gnu: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170730091346.34fa067d@cbaines.net \
--to=mail@cbaines.net \
--cc=27853-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.