From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH] git-download: Speed up 'git-predicate'. Date: Wed, 26 Jul 2017 10:58:38 +0100 Message-ID: <20170726105838.49ee372b@cbaines.net> References: <87zidk2c4g.fsf@gnu.org> <20170619071443.23122-1-mail@cbaines.net> <87fuetggn9.fsf@gnu.org> <20170716114220.55d845e9@cbaines.net> <87o9s8b43s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/=Zeh9dA6E_2Tn9VXye+6DGS"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daJ5c-0007tu-9w for guix-devel@gnu.org; Wed, 26 Jul 2017 05:58:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daJ5Y-0006BC-Di for guix-devel@gnu.org; Wed, 26 Jul 2017 05:58:48 -0400 In-Reply-To: <87o9s8b43s.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel@gnu.org --Sig_/=Zeh9dA6E_2Tn9VXye+6DGS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 25 Jul 2017 23:26:15 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hi! >=20 > Christopher Baines skribis: >=20 > > I've had a little look at the performance, and I think this > > approach of using a vhash might be slower, but not by much. The > > biggest difference I saw for the guix repository was 0.008 seconds, > > and for smart-answers was 0.6 seconds. > > > > I'm happy to go ahead with either though, obviously these > > performance differences don't matter compared to the current > > performance for large repositories. =20 >=20 > I=E2=80=99ve finally pushed the patch with my changes as > f135b4ae8397d2c501150d3ead3e0603e770ce3f. >=20 > Seems to work well but let me know if you encounter any issues. >=20 > Thanks, and sorry for the delay! No problem, thanks for your help :) --Sig_/=Zeh9dA6E_2Tn9VXye+6DGS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAll4Z85fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XecPg/+OcxayZkIqgaCvgrDcH6E9wruV4lyg5koBgRg8w5DVX9QDOtveUpFVen1 SF9QUjffNHIJjxy9A0JfGSUK4ohydxFIh1spyfi6IjKDeDzgRBRHtmRYQ6q74DXW qiqab2FxM3nexsayN9mwnaZwEZj9EjO9SL7ceQoddXjsKqv8+Moc6hq6uNZkj4N/ Z+gUEZCAKZd8Y2QRlsRerDplhvLjDzErgcMv1IAXm7MT5eIHXJyamOIxUL+nZ3yz kL2dufJsSLDBbGZ7pS3OvXfMO3ICNkkD/uX5WZH4+MgHK1ItUXJ1LVIL7WLo84Jo opVreTYaR6Tjx8PEhfh+h00qDttzqe6utnqPegWPC2hSEUtBjU16mPilkkEN2KLD JqLUxQmboorqu9MeA9dN5PDJLAMJvH78eJmMImUfSG9Nvg4BFX8cBpa9zOMtyHyR Mzf+GM8DZW5SBEMyERGrsnlS4z91OXLyp/MtiW3FwsuRg6VtW+GyQdG9O7KEJ8Or NN2EWitzsdWpklYK6rGSsfGWYR5Tvlk78zidj2SOv1Ar7+ntDgpWva8oUQIeQajB ct0puYjXLbJf9Vn9j3ldB9KJVTmVdQbLiYBfL0f2OB4RTlyMdjDNc7hOfLKcdH4g HMDrtj5h8KQzyZ0T7BlJPHVRHpUX1wzZxywDQ/DOmjY0kJsQHvM= =rKvZ -----END PGP SIGNATURE----- --Sig_/=Zeh9dA6E_2Tn9VXye+6DGS--