From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?] Date: Wed, 26 Jul 2017 06:56:51 +0000 Message-ID: <20170726065651.qvsz25b44txl6et7@abyayala> References: <20170702201344.dvqpopouvpbzr4c2@abyayala> <20170723101547.3oi5uu2xhi625njp@abyayala> <20170725184936.GA32001@jasmine.lan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p7nzagfjnixs3tlc" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daGGj-0001RM-My for bug-guix@gnu.org; Wed, 26 Jul 2017 02:58:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daGGg-0007Y0-Hh for bug-guix@gnu.org; Wed, 26 Jul 2017 02:58:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53982) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daGGg-0007Xu-D4 for bug-guix@gnu.org; Wed, 26 Jul 2017 02:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1daGGf-0004XT-RK for bug-guix@gnu.org; Wed, 26 Jul 2017 02:58:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20170725184936.GA32001@jasmine.lan> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Leo Famulari Cc: 27556@debbugs.gnu.org --p7nzagfjnixs3tlc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Leo Famulari transcribed 2.3K bytes: > On Sun, Jul 23, 2017 at 10:15:47AM +0000, ng0 wrote: > > ----- Forwarded message ----- > >=20 > > > Date: Sun, 23 Jul 2017 18:21:19 +0900 (JST) > > > To: ng0 > > > Cc: daisuken@users.sourceforge.net > > > Subject: Re: why has the hash for libpng-apng 1.6.28 changed? > > >=20 > > > Hi, > > >=20 > > > I calculated the hash for libpng-apng files on my local orignals. > > >=20 > > > md5sum > > > 9f2b36bccf89c5f4097111f0f73c1798 libpng-1.6.28-apng.patch.README.txt > > > fca7c6d87c8352e645facefc2e1dd153 libpng-1.6.28-apng.patch.gz > > >=20 > > > sha1sum > > > cb620589ecf9c28a4ecc00e6225dd41ca660a959 libpng-1.6.28-apng.patch.RE= ADME.txt > > > 4fa952f5ad374fce8d478b7e54ee4298a0b8d159 libpng-1.6.28-apng.patch.gz > > >=20 > > > Local file time stamps are > > > 2017-01-06 21:02:10.938833896 +0900 libpng-1.6.28-apng.patch.README.= txt > > > 2017-01-06 21:02:10.938833896 +0900 libpng-1.6.28-apng.patch.gz > > >=20 > > > That values equals on sourceforge.net. > > > https://sourceforge.net/projects/libpng-apng/files/libpng16/1.6.28/ > > >=20 > > > I don't really understand what happend, but it look just fine. > > >=20 > > > Cheers, > > > --- > > > daisuken@users.sourceforge.net >=20 > Okay, this doesn't help us, so we need to inspect the different tarballs > ourselves. Do you have an old copy of the patch you can share? Yes. I mean no. I am not sure. I have libpng-apng git checkout and also the 1.6.25 extracted tarball directory (but not sure when I got it), and the tarballs for 1.6.5 and 1.6.28. But I think I found our problem: user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.28-apng.patch.gz 0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.25-apng.patch.gz 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5 (inputs `(("apng" ,(origin (method url-fetch) (uri (string-append "mirror://sourceforge/libpng-apng/libpng16/" version "/libpng-" version "-apng.patch.gz")) (sha256 (base32 "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5")))))) My really strong guess is that we never updated the hash for libpng-apng when the libpng was updated fron which libpng-apng inherits its version. I don't have the time to look at our git history right now, but you could do that, look at wether libpng-apng was touched since 1.6.25->1.6.28 update of libpng. user@shadownet ~/re-src$ ls -al *png* ; ls -al tarballs/*png* libpng-1.6.25: total 3416 drwxr-xr-x 8 user users 4096 Mar 24 14:51 ./ drwxr-xr-x 282 user users 12288 Jul 22 09:39 ../ -rw-r--r-- 1 user users 44739 Sep 1 2016 aclocal.m4 -rw-r--r-- 1 user users 1207 Sep 1 2016 ANNOUNCE drwxr-xr-x 2 user users 4096 Mar 24 14:51 arm/ -rwxr-xr-x 1 user users 7979 Aug 3 2015 autogen.sh -rw-r--r-- 1 user users 285838 Sep 1 2016 CHANGES -rw-r--r-- 1 user users 30349 Sep 1 2016 CMakeLists.txt -rwxr-xr-x 1 user users 7333 Feb 21 2015 compile -rwxr-xr-x 1 user users 42938 Feb 21 2015 config.guess -rw-r--r-- 1 user users 3307 Sep 1 2016 config.h.in -rwxr-xr-x 1 user users 35987 Feb 21 2015 config.sub -rwxr-xr-x 1 user users 477565 Sep 1 2016 configure -rw-r--r-- 1 user users 14688 Sep 1 2016 configure.ac drwxr-xr-x 15 user users 4096 Mar 24 14:51 contrib/ -rwxr-xr-x 1 user users 23566 Feb 21 2015 depcomp -rw-r--r-- 1 user users 40303 Sep 1 2016 example.c -rw-r--r-- 1 user users 17971 Sep 1 2016 INSTALL -rwxr-xr-x 1 user users 14675 Feb 21 2015 install-sh -rw-r--r-- 1 user users 270700 Sep 1 2016 libpng.3 -rw-r--r-- 1 user users 2396 Sep 1 2016 libpng-config.in -rw-r--r-- 1 user users 228244 Sep 1 2016 libpng-manual.txt -rw-r--r-- 1 user users 293 Sep 1 2016 libpng.pc.in -rw-r--r-- 1 user users 764 Sep 1 2016 libpngpf.3 -rw-r--r-- 1 user users 4937 Sep 1 2016 LICENSE -rw-r--r-- 1 user users 324089 Sep 1 2016 ltmain.sh -rw-r--r-- 1 user users 13620 Sep 1 2016 Makefile.am -rw-r--r-- 1 user users 89190 Sep 1 2016 Makefile.in drwxr-xr-x 2 user users 4096 Mar 24 14:51 mips/ -rwxr-xr-x 1 user users 6872 Feb 21 2015 missing -rw-r--r-- 1 user users 2432 Sep 1 2016 png.5 -rw-r--r-- 1 user users 2498 Jul 12 2000 pngbar.jpg -rw-r--r-- 1 user users 2399 Jul 12 2000 pngbar.png -rw-r--r-- 1 user users 155048 Sep 1 2016 png.c -rw-r--r-- 1 user users 22842 Sep 1 2016 pngconf.h -rw-r--r-- 1 user users 5368 Sep 1 2016 pngdebug.h -rw-r--r-- 1 user users 29224 Sep 1 2016 pngerror.c -rw-r--r-- 1 user users 33379 Sep 1 2016 pngget.c -rw-r--r-- 1 user users 143481 Sep 1 2016 png.h -rw-r--r-- 1 user users 12343 Sep 1 2016 pnginfo.h -rw-r--r-- 1 user users 8353 Sep 1 2016 pngmem.c -rw-r--r-- 1 user users 2069 Aug 26 2004 pngnow.png -rw-r--r-- 1 user users 31617 Sep 1 2016 pngpread.c -rw-r--r-- 1 user users 83266 Sep 1 2016 pngpriv.h -rw-r--r-- 1 user users 141254 Sep 1 2016 pngread.c -rw-r--r-- 1 user users 3956 Sep 1 2016 pngrio.c -rw-r--r-- 1 user users 168573 Sep 1 2016 pngrtran.c -rw-r--r-- 1 user users 142873 Sep 1 2016 pngrutil.c -rw-r--r-- 1 user users 49969 Sep 1 2016 pngset.c -rw-r--r-- 1 user users 20036 Sep 1 2016 pngstruct.h -rw-r--r-- 1 user users 61255 Sep 1 2016 pngtest.c -rw-r--r-- 1 user users 8695 Jan 6 2013 pngtest.png -rw-r--r-- 1 user users 25150 Sep 1 2016 pngtrans.c -rw-r--r-- 1 user users 497 Sep 1 2016 pngusr.dfa -rw-r--r-- 1 user users 5655 Sep 1 2016 pngwio.c -rw-r--r-- 1 user users 76028 Sep 1 2016 pngwrite.c -rw-r--r-- 1 user users 15391 Sep 1 2016 pngwtran.c -rw-r--r-- 1 user users 80139 Sep 1 2016 pngwutil.c drwxr-xr-x 5 user users 4096 Mar 24 14:51 projects/ -rw-r--r-- 1 user users 11403 Sep 1 2016 README drwxr-xr-x 2 user users 4096 Mar 24 14:51 scripts/ -rwxr-xr-x 1 user users 4640 Feb 21 2015 test-driver drwxr-xr-x 2 user users 4096 Mar 24 14:51 tests/ -rw-r--r-- 1 user users 1252 Aug 15 2016 TODO libpng-apng-code: total 2764 drwxr-xr-x 6 user users 4096 Jul 22 08:53 ./ drwxr-xr-x 282 user users 12288 Jul 22 09:39 ../ -rw-r--r-- 1 user users 322880 Jul 22 08:53 aclocal.m4 -rw-r--r-- 1 user users 1728 Jul 22 08:53 ANNOUNCE -rwxr-xr-x 1 user users 877 Jul 22 08:53 autogen.sh -rw-r--r-- 1 user users 141161 Jul 22 08:53 CHANGES -rw-r--r-- 1 user users 12406 Jul 22 08:53 CMakeLists.txt -rwxr-xr-x 1 user users 44941 Jul 22 08:53 config.guess -rw-r--r-- 1 user users 2218 Jul 22 08:53 config.h.in -rwxr-xr-x 1 user users 34423 Jul 22 08:53 config.sub -rwxr-xr-x 1 user users 411663 Jul 22 08:53 configure -rw-r--r-- 1 user users 3862 Jul 22 08:53 configure.ac drwxr-xr-x 7 user users 4096 Jul 22 08:53 contrib/ -rwxr-xr-x 1 user users 18615 Jul 22 08:53 depcomp -rw-r--r-- 1 user users 30668 Jul 22 08:53 example.c drwxr-xr-x 8 user users 4096 Jul 22 08:53 .git/ -rw-r--r-- 1 user users 5175 Jul 22 08:53 INSTALL -rwxr-xr-x 1 user users 13663 Jul 22 08:53 install-sh -rw-r--r-- 1 user users 141280 Jul 22 08:53 libpng-1.4.8.txt -rw-r--r-- 1 user users 184598 Jul 22 08:53 libpng.3 -rwxr-xr-x 1 user users 2379 Jul 22 08:53 libpng-config.in -rw-r--r-- 1 user users 293 Jul 22 08:53 libpng.pc.in -rw-r--r-- 1 user users 19036 Jul 22 08:53 libpngpf.3 -rw-r--r-- 1 user users 4192 Jul 22 08:53 LICENSE -rwxr-xr-x 1 user users 253153 Jul 22 08:53 ltmain.sh -rw-r--r-- 1 user users 4541 Jul 22 08:53 Makefile.am -rw-r--r-- 1 user users 60025 Jul 22 08:53 Makefile.in -rwxr-xr-x 1 user users 11419 Jul 22 08:53 missing -rw-r--r-- 1 user users 2408 Jul 22 08:53 png.5 -rw-r--r-- 1 user users 2498 Jul 22 08:53 pngbar.jpg -rw-r--r-- 1 user users 2399 Jul 22 08:53 pngbar.png -rw-r--r-- 1 user users 26634 Jul 22 08:53 png.c -rw-r--r-- 1 user users 47082 Jul 22 08:53 pngconf.h -rw-r--r-- 1 user users 12267 Jul 22 08:53 pngerror.c -rw-r--r-- 1 user users 28616 Jul 22 08:53 pngget.c -rw-r--r-- 1 user users 124654 Jul 22 08:53 png.h -rw-r--r-- 1 user users 16821 Jul 22 08:53 pngmem.c -rw-r--r-- 1 user users 2069 Jul 22 08:53 pngnow.png -rw-r--r-- 1 user users 54513 Jul 22 08:53 pngpread.c -rw-r--r-- 1 user users 37962 Jul 22 08:53 pngpriv.h -rw-r--r-- 1 user users 45779 Jul 22 08:53 pngread.c -rw-r--r-- 1 user users 5313 Jul 22 08:53 pngrio.c -rw-r--r-- 1 user users 141155 Jul 22 08:53 pngrtran.c -rw-r--r-- 1 user users 107313 Jul 22 08:53 pngrutil.c -rw-r--r-- 1 user users 39242 Jul 22 08:53 pngset.c -rw-r--r-- 1 user users 54601 Jul 22 08:53 pngtest.c -rw-r--r-- 1 user users 8608 Jul 22 08:53 pngtest.png -rw-r--r-- 1 user users 20655 Jul 22 08:53 pngtrans.c -rw-r--r-- 1 user users 7648 Jul 22 08:53 pngwio.c -rw-r--r-- 1 user users 47855 Jul 22 08:53 pngwrite.c -rw-r--r-- 1 user users 16934 Jul 22 08:53 pngwtran.c -rw-r--r-- 1 user users 89100 Jul 22 08:53 pngwutil.c drwxr-xr-x 6 user users 4096 Jul 22 08:53 projects/ -rw-r--r-- 1 user users 13273 Jul 22 08:53 README drwxr-xr-x 2 user users 4096 Jul 22 08:53 scripts/ -rwxr-xr-x 1 user users 43 Jul 22 08:53 test-pngtest.sh -rw-r--r-- 1 user users 1443 Jul 22 08:53 TODO -rw-r--r-- 1 user users 10720 Jan 10 2017 tarballs/libpng-1.6.25-apng.pat= ch.gz -rw-r--r-- 1 user users 982204 Jan 10 2017 tarballs/libpng-1.6.25.tar.xz -rw-r--r-- 1 user users 819 Jan 10 2017 tarballs/libpng-1.6.25.tar.xz.a= sc -rw-r--r-- 1 user users 10766 Jan 10 2017 tarballs/libpng-1.6.28-apng.pat= ch.gz --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --p7nzagfjnixs3tlc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAll4PTMACgkQ4i+bv+40 hYjYgg//fHJe+IoBoHeRXcK2lL4ZGUCYDknNjaXbVgp9E8MGke8AVYDZD+BaevOU 9JZhorW/fS57dhK0DiDnldjErlZiDa5T0aaYP3C6naQCUdRrCAQNU3Utna0reePg JONDPDcL31alzN/T1UJ4Ox7MvIdOheJYUvFAbRZgxp+EEvB+6ZcYSygyPauh0YK7 m7U1lynB6+htKJcuQvvdOic3zZIQWCJKxAZdBv/bgcZwFxSAtBUpql+oNidJMr8y EQgdgo//Oi3TV15QC8sRux3Rwdajmb2nkLpSc/48DHmaXnDFtJHJxYx5vtdbX3GB 4yeY18zCFX+UTSdJfw0goxF4gxMpza7gnzUlp1razByAjBzegCF+qIxMO2IqGuT1 cGO18QZ2yh6ntxKKKpalfBQxq5OkMpx4GEAqxoY8eNKI0wfnGBh7sohQFW8TVZWZ hnfr3bpO6bwVxdO5zZUYZBXyBgNqW+zPUERlSi6x91bYa9hKIGfMZ/YihbIiqLXw wO5G3LYWxsY49G914rNgawHcfeijRBjjvHwdA5GmnuWvdLY0mn7tstNUWJvdZS+3 JNdH3n0C6AKw1+caMFtkXFgNyYL23rokGOSBChKRKqnkEoupj85vBrfYgx684R3m CZSYYflaMM5djNUiU1EQgHnm91h4TLB927ZUima1phA2BvRv0eg= =MBNk -----END PGP SIGNATURE----- --p7nzagfjnixs3tlc--