From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYwrx-0004Na-RR for guix-patches@gnu.org; Sat, 22 Jul 2017 12:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYwru-0006HY-Bf for guix-patches@gnu.org; Sat, 22 Jul 2017 12:03:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYwru-0006HF-7n for guix-patches@gnu.org; Sat, 22 Jul 2017 12:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dYwrt-0005mI-V0 for guix-patches@gnu.org; Sat, 22 Jul 2017 12:03:01 -0400 Subject: [bug#27790] text-editor: mg Resent-Message-ID: Date: Sat, 22 Jul 2017 16:02:02 +0000 From: ng0 Message-ID: <20170722160202.47axhgthb4qd3dzo@abyayala> References: <20170722113613.shefcwrn3m2t6suu@abyayala> <0be93d82-ed4c-6024-62c9-426ed6e3a268@tobias.gr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pukhao7ezmwcg56x" Content-Disposition: inline In-Reply-To: <0be93d82-ed4c-6024-62c9-426ed6e3a268@tobias.gr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 27790@debbugs.gnu.org --pukhao7ezmwcg56x Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice transcribed 5.9K bytes: > ng0, >=20 > Thanks! Some minor points, most of which can be taken care of by the > committer (i.e. probably me) when they push: >=20 > ng0 wrote on 22/07/17 at 13:36: > > From d1cae87a9b13b5624deb16666a1da3333bd05681 Mon Sep 17 00:00:00 2001 > > From: ng0 > > Date: Sat, 22 Jul 2017 11:31:37 +0000 > > Subject: [PATCH] gnu: Add mg. > >=20 > > * gnu/packages/text-editors.scm (mg): New variable. > > --- > > gnu/packages/text-editors.scm | 57 +++++++++++++++++++++++++++++++++++= +++++++- > > 1 file changed, 56 insertions(+), 1 deletion(-) > >=20 > > diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.= scm > > index 98df48119..9277dd1f5 100644 > > --- a/gnu/packages/text-editors.scm > > +++ b/gnu/packages/text-editors.scm > > @@ -3,7 +3,7 @@ > > ;;; Copyright =C2=A9 2016 Carlo Zancanaro > > ;;; Copyright =C2=A9 2017 Eric Bavier > > ;;; Copyright =C2=A9 2017 Feng Shu > > -;;; Copyright =C2=A9 2017 ng0 > > +;;; Copyright =C2=A9 2017 ng0 > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -34,6 +34,7 @@ > > #:use-module (gnu packages gcc) > > #:use-module (gnu packages glib) > > #:use-module (gnu packages gtk) > > + #:use-module (gnu packages libbsd) > > #:use-module (gnu packages lua) > > #:use-module (gnu packages ncurses) > > #:use-module (gnu packages pkg-config) > > @@ -227,3 +228,57 @@ Wordstar-, EMACS-, Pico, Nedit or vi-like key bind= ings. e3 can be used on > > 16, 32, and 64-bit CPUs.") > > (supported-systems '("x86_64-linux" "i686-linux")) > > (license license:gpl2+))) > > + > > +(define-public mg > > + (package > > + (name "mg") > > + (version "20170401") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "http://homepage.boetes.org/software/mg/" > > + "mg-" version ".tar.gz")) >=20 > HTTPS works, so let's use it just because we can. Same for home-page. Ah. It does not redirect http->https though, so I didn't notice. > > + (sha256 > > + (base32 > > + "1arasswgdadbb265rahq3867r9s54jva6k4m3p5n0f8mgjqhhdha")))) > > + (build-system gnu-build-system) > > + (arguments > > + `(#:tests? #f ; There is no testsuite >=20 > s/There/there/, and s/testsuite/test suite/ since I'm already being > pedantic. >=20 > > + #:make-flags (list "CC=3Dgcc") > > + #:phases > > + (modify-phases %standard-phases > > + (delete 'configure) ; There is no configure script >=20 > Same here. >=20 > > + (add-before 'build 'replace-usr > > + (lambda* (#:key outputs #:allow-other-keys) > > + (substitute* "GNUmakefile" > > + (("/usr/bin/") "") > > + (("/usr/local") > > + (assoc-ref outputs "out"))) > > + #t)) > > + (add-before 'build 'correct-location-of-difftool > > + (lambda _ > > + (substitute* "buffer.c" > > + (("/usr/bin/diff") > > + (which "diff"))) >=20 > Cool. I learn new things every day. >=20 > > + #t)) > > + (add-before 'install 'install-tutorial > > + (lambda* (#:key outputs #:allow-other-keys) > > + ;; This isn't handled by install but is expect >=20 > s/expect/expected/, but: >=20 > > + ;; by the tutorial part of mg to be present. >=20 > What exactly do you mean by =E2=80=98the tutorial part of mg=E2=80=99? I = tried C-h t > with no result, and the only mentions of =E2=80=98tutorial=E2=80=99 in th= e tarball are > in the manual page and the tutorial itself. I'm not sure. It is good to have it I think, but this wasn't my idea. So maybe just drop the comment? > > + (let* ((out (assoc-ref outputs "out")) > > + (doc (string-append out "/share/doc/mg"))) > > + (install-file "tutorial" > > + (string-append doc "/tutorial")) > > + #t)))))) > > + (inputs > > + `(("ncurses" ,ncurses) > > + ("libbsd" ,libbsd))) > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (home-page "http://homepage.boetes.org/software/mg/") > > + (synopsis "OpenBSD variant of the editor mg") >=20 > This appears to be the canonical modern =E2=80=98portable=E2=80=99 mg, so= I'd move the > OpenBSD bit to the description. We're packaging this as mg, after all, > not mg-openbsd. What do you think of "Small and fast text editor in the > style of GNU Emacs"? Ok. > > + (description > > + "Mg is a public domain text editor intended to loosely resemble > > +GNU Emacs, while still retaining fast speed and a small memory footpri= nt. > > +It is based on MicroEMACS.") >=20 > =E2=80=98Public-domain=E2=80=99 can be dropped, and IMO so can its MicroE= MACS history. > This does leave us with a very short description indeed... Ok. > > + (license license:public-domain))) >=20 > True freedom=E2=84=A2! >=20 > T G-R >=20 thanks! --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --pukhao7ezmwcg56x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAllzdvoACgkQ4i+bv+40 hYiRohAAq7inujyLa1+FYo2eV3RJt0QUei1uElOsjfiDczhk3Yx5lcnqlBQ1wAzA vEugm/kfXmt/MxedKdTUFRZ7daKkFV4MQBm0lBHVcssOjIVla0AZPf2Eu5vNpuFc TVjKi7hP/D21UP8vBnLrA9oNKQHyXUGzbUHdA3qRruu+Ymjui9XkYKbWNQqDfXlq W1tQONYH5f6W8UdazD6fgr7xaAZ8s4WcNlKrW1p1+4M+RkYcyzvLMSYPt4Kt15B5 6L24LZJ1uut6IuBaENafbor4ALmKa/rcS/Er81zYhBnn+RmFc/cOiCFTUazjqruq 2BvrXs78XF5udMiTWh+AWbw3PE4hxnTyHS7DRFHFrTOzn/2Qv4x+lhfkIaXCvejG ltMNeOXYnOyxfiyJqAeE19MA8ZeH8nYX0c+HsgDIYKldS2gubz4H4vj/Wyf4D1XU qnuSVfnHrlmUcKoA6TmK9PU0o9OC844MkuVEIYQr/Dq4JoRuLNTOoFjLHZr/Xn48 +VVnDR3vbrXyK/gXcH6oVPUo93W621C6/Gsie6AX6+G5jOoSYLTO4ieFSm6zUXzH elMOPn9Kx3lY44yr26FQ9PXE8KzGJyWTO8jhSZHTaZzRoZOay0fStwUJp6h/lIBb EGyWbbFYViRTWjyjCm89XNOBOF9xrj9gaxYaYy2l13khNpgdl7M= =n8Zy -----END PGP SIGNATURE----- --pukhao7ezmwcg56x--