From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWTUw-0002oc-1Y for guix-patches@gnu.org; Sat, 15 Jul 2017 16:17:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWTUs-000758-Q5 for guix-patches@gnu.org; Sat, 15 Jul 2017 16:17:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWTUs-00074r-Hm for guix-patches@gnu.org; Sat, 15 Jul 2017 16:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dWTUs-0008Ck-DH for guix-patches@gnu.org; Sat, 15 Jul 2017 16:17:02 -0400 Subject: bug#27710: [PATCH] gnu: go@1.8: Fix test failure. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sat, 15 Jul 2017 16:15:42 -0400 From: Leo Famulari Message-ID: <20170715201542.GA18529@jasmine.lan> References: <87y3rpprfu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline In-Reply-To: <87y3rpprfu.fsf@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Vong Cc: 27710-done@debbugs.gnu.org --cmJC7u66zC7hs+87 Content-Type: multipart/mixed; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 16, 2017 at 12:59:01AM +0800, Alex Vong wrote: > Tags: fixed-upstream > Forwarded: https://github.com/golang/go/issues/20007 >=20 > Hello, >=20 > This patch fixes the test failure in core-updates. I've tried to > cherry-pick upstream's commit, but it doesn't work. So I fall back to > fix it directly instead. The bug has already been fixed upstream, and > the fix will be in the next release (1.9). See [0] for details. >=20 > From 023f866f8838df457639a38af9c2c733e445435d Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Sun, 16 Jul 2017 00:41:17 +0800 > Subject: [PATCH] gnu: go@1.8: Fix test failure. >=20 > * gnu/packages/golang.scm (go-1.8)[arguments]: Escape braces in test data= in > 'prebuild' phase. Thanks! Pushed as eaca9ff07e4762c3d33e3090bab999c7cf74c98a. BTW, I've attached an update to the latest Go, 1.9beta2. I can successfully build Syncthing with it. --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-WIP-go-Update-to-1.9beta2.patch" Content-Transfer-Encoding: quoted-printable =46rom c607f2857d223d377ad905a6a1f063c6aa6da22e Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 14 Jul 2017 14:15:54 -0400 Subject: [PATCH] WIP: go: Update to 1.9beta2. * gnu/packages/golang.scm (go-1.8): Replace with ... (go-1.9): ... new variable. [arguments]: Adjust the pre-build phase accordingly. --- gnu/packages/golang.scm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 70cae6d87..a7facf4ed 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -199,11 +199,11 @@ garbage collection, various safety features and in th= e style of communicating sequential processes (CSP) concurrent programming features added.") (license license:bsd-3))) =20 -(define-public go-1.8 +(define-public go-1.9 (package (inherit go-1.4) (name "go") - (version "1.8.3") + (version "1.9beta2") (source (origin (method url-fetch) @@ -211,7 +211,7 @@ sequential processes (CSP) concurrent programming featu= res added.") name version ".src.tar.gz")) (sha256 (base32 - "19lzv4lqixj3v2gjaff0fdbbmgsq5r8lrfd61z2zvp778wjflpaz")))) + "1hx8vab9qbwpk75lfx1zvj9a6ssalp1hpa1pp0fyzcn3x4lip8ac")))) (arguments (substitute-keyword-arguments (package-arguments go-1.4) ((#:phases phases) @@ -242,7 +242,7 @@ sequential processes (CSP) concurrent programming featu= res added.") ;; Add libgcc to runpath (substitute* "cmd/link/internal/ld/lib.go" (("!rpath.set") "true")) - (substitute* "cmd/go/build.go" + (substitute* "cmd/go/internal/work/build.go" (("cgoldflags :=3D \\[\\]string\\{\\}") (string-append "cgoldflags :=3D []string{" "\"-rpath=3D" gcclib "\"" @@ -265,7 +265,9 @@ sequential processes (CSP) concurrent programming featu= res added.") (substitute* file ((regex all before test_name) (string-append before "Disabled" test_name))))) - '(("net/net_test.go" "(.+)(TestShutdownUnix.+)") + '(;; See https://github.com/golang/go/commit/81ed9ca1d41= 1f0bd8738ea60b3a8045446ad85fc + ("cmd/go/go_test.go" "(.+)(TestExecutableGOROOT.+)") + ("net/net_test.go" "(.+)(TestShutdownUnix.+)") ("net/dial_test.go" "(.+)(TestDialTimeout.+)") ("os/os_test.go" "(.+)(TestHostname.+)") ("time/format_test.go" "(.+)(TestParseInSydney.+)") @@ -366,4 +368,4 @@ sequential processes (CSP) concurrent programming featu= res added.") `(("go" ,go-1.4) ,@(package-native-inputs go-1.4))))) =20 -(define-public go go-1.8) +(define-public go go-1.9) --=20 2.13.3 --HlL+5n6rz5pIUxbD-- --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAllqd+4ACgkQJkb6MLrK fwiLqxAA4ySYAfOltAenFQfk/utzHsA0b3UeNaBmD+fpNff/2x5vkR6cJNLScMBF szgaYUf9ZwnyW/KwFK5ImZQydaEsGCfLB2Mkqt2fB47Z+uF3qItEDNhvzQP1qgu8 as3NXM4MxZ3rHtQiQLvYcZ7nTKEe109uJdW/yX+983baZjP2Sm08tIxuN+z+BwzF rsCJXTKSq5Um9DqkRc03mEovsPCWk9alFdf8/GUkBk/2v+WWOA3wWaaLGDids8t+ rh++pJ8GfJTSRkH3j3HHz9WOc12y+4kaZzKnLR9BiuTbSoN9qpao/fvb0d5f5jVd j/df6u0ClexiD0+quZammC6J17vlJCvI1beR6cIKwNVAWdMeRngncwQk8eejBK12 Ap/82c9oL9xUVJVg4DueOJDB+7Sv5T5N1wKw2TW6sQ2+3kiH+Ru91rYN2BiIeaQo EQKFzTReNBmiMVhguAODQatqOvqmU7fIL50vsBD75Ys1wkU7FQCXFSDPClxkyxKV EqE/4DRN8lw8Dua9Vh2mjKF2Z4YGnCKMMoqovafR4Xd1cwwRjQiT3V1KOE/S7/YI nSstrwR0l17MNIxEkjfhut+XIMvre8zRLFzC+FZxJ3AXgLSV/HeXyn91eIV+DI9Z cZ50HEUZf9xfyxmQXu+lVT+GhUSQNXFc8IkMzIK7Y43lSaCui0w= =ksJL -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87--