Re: 01/03: gnu: Add ncurses-with-gpm.

Re: 01/03: gnu: Add ncurses-with-gpm.

[Ludovic Courtès]

Heya Danny,

I’m really happy to see you continue John’s heroic work on the
installer!  I’ll be happy to give it a spin when you deem appropriate.

dannym@scratchpost.org (Danny Milosavljevic) skribis:

> commit 6b6c8317097482487c41f302a2ae4fc27d9220f0
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> Date:   Fri Jul 7 07:07:51 2017 +0200
>
>     gnu: Add ncurses-with-gpm.
>     
>     * gnu/packages/linux.scm (ncurses/gpm): New variable.

Side note:

> +(define-public ncurses/gpm
> +  (package
> +    (inherit ncurses)
> +    (name "ncurses-with-gpm")
> +    (arguments
> +        (substitute-keyword-arguments (package-arguments ncurses)
> +         ((#:configure-flags cf)
> +          `(cons (string-append "--with-gpm=" (assoc-ref %build-inputs "gpm") "/lib/libgpm.so.2") ,cf))))
> +    (inputs
> +     `(("gpm" ,gpm)))))

Does it need the full file name of the .so?  Would be nicer if this
could be avoided, to avoid breakage in the future.

(BTW, please wrap lines to 80 chars.  :-))

Ludo’.

Re: 01/03: gnu: Add ncurses-with-gpm.

[Danny Milosavljevic]

Hi Ludo,

On Fri, 07 Jul 2017 13:14:39 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> I’m really happy to see you continue John’s heroic work on the
> installer!  I’ll be happy to give it a spin when you deem appropriate.

Okay.  Still some loose ends to tie up first :)

> > +(define-public ncurses/gpm
> > +  (package
> > +    (inherit ncurses)
> > +    (name "ncurses-with-gpm")
> > +    (arguments
> > +        (substitute-keyword-arguments (package-arguments ncurses)
> > +         ((#:configure-flags cf)
> > +          `(cons (string-append "--with-gpm=" (assoc-ref %build-inputs "gpm") "/lib/libgpm.so.2") ,cf))))
> > +    (inputs
> > +     `(("gpm" ,gpm)))))  
> 
> Does it need the full file name of the .so?  Would be nicer if this
> could be avoided, to avoid breakage in the future.

I tried it - apparently it does need it.

With all this "ncurses/fixed" stuff in master, should I make it inherit from ncurses/fixed ?

Re: 01/03: gnu: Add ncurses-with-gpm.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On Tue, Jul 11, 2017 at 11:42:23AM +0200, Danny Milosavljevic wrote:
> With all this "ncurses/fixed" stuff in master, should I make it
> inherit from ncurses/fixed ?

Recently, Mark added the macro (package/inherit) which does the Right
Thing when inheriting from a grafted package:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=bedba064267490f2d9f7ee44e5ec103aacc82611

There are some recent examples in the commit log.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]