bug#27520: [PATCH v2] build, vm: Use "GuixSD" or "GUIXSD" as volume label.

[Danny Milosavljevic <dannym@scratchpost.org>]

Hi Ludo,

On Mon, 10 Jul 2017 12:33:39 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> > +++ b/gnu/build/vm.scm
> > @@ -431,7 +431,7 @@ passing it a directory name where it is mounted."
> >            (lambda (port)
> >              (format port
> >                      "insmod part_msdos~@
> > -                    search --set=root --label gnu-disk-image~@
> > +                    search --set=root --label GuixSD~@
> >                      configfile /boot/grub/grub.cfg~%")))  
> 
> This won’t cause problems with ISO images, right?

Good question.

I successfully tested it in qemu (both iso9660 and normal disk-image).

I also ran the system checks.  Some work, some don't work.  The bootup part does generally work.

But I'm not that knowledgeable with UEFI, so no idea whether ISO9660 bootup would even use this UEFI wrapper thing.

Anyway, it doesn't worsen anything so I pushed it to master, commit 651de2bdb5fd451c50933dcf8d647d470d826261.

Thanks!

P.S. Some system tests look not-so-good either with or without the patch applied:

Jul 10 15:30:54 localhost avahi-daemon[438]: simple-protocol.c: Got RESOLVE-ADDRESS request for 'fe80::5054:ff:fe12:3456'.
Mon Jul 10 15:30:54 2017 - 341: add new entry "komputilo.local" of type GETAI for hosts to cache (first)
ice-9/eval.scm:387:11: In procedure eval:
ice-9/eval.scm:387:11: In procedure getaddrinfo: System error
ice-9/eval.scm:387:11: In procedure eval:
ice-9/eval.scm:387:11: In procedure gethost: Host name lookup failure
QEMU runs as PID 3
connected to QEMU's monitor
read QEMU monitor prompt
connected to guest REPL
%%%% Starting test avahi  (Writing full log to "avahi.log")
marionette is ready
/gnu/store/mw90mh1jb8z4s67k5pi2pk9zid0cqgjl-nss-mdns-builder:1: FAIL getaddrinfo .local

;;; (gethostbyname #f)
/gnu/store/mw90mh1jb8z4s67k5pi2pk9zid0cqgjl-nss-mdns-builder:1: FAIL gethostbyname .local
# of expected passes      3
# of unexpected failures  2
note: keeping build directory `/tmp/guix-build-nss-mdns.drv-0'
builder for `/gnu/store/b4ikx6m6952a5q5hx8576pismks8mq72-nss-mdns.drv' failed with exit code 1
@ build-failed /gnu/store/b4ikx6m6952a5q5hx8576pismks8mq72-nss-mdns.drv - 1 builder for `/gnu/store/b4ikx6m6952a5q5hx8576pismks8mq72-nss-mdns.drv' failed with exit code 1
TOTAL: 19
PASS: /gnu/store/jsmkjv57sdycy89whbpj8w0ggzladmy1-basic
PASS: /gnu/store/i3rpc4na0s8n3ys37qlrzbmsd63g0x4n-mcron
PASS: /gnu/store/dx2ibskh8a6qirk20n19d5xam2wk3yzy-opensmtpd-test
PASS: /gnu/store/xgmmghm577xp41w6j1xlzr912x7c1l72-prosody
PASS: /gnu/store/dl4bjcwwgrrp84mmfm4gcxrp9mfvcwqs-inetd-test
PASS: /gnu/store/9hg2bp1yk5mdl3wqgfkzvdxm1qmkk6pz-nfs
PASS: /gnu/store/658s8abgckc4anzlqh9sn17vjhngnyy1-openssh
PASS: /gnu/store/p6visdc6p4najg7dy4rfpy201136ysn5-dropbear
PASS: /gnu/store/kynb05cj7kd5kfh9690xwm0i8gvc536z-nginx-test
FAIL: /gnu/store/90484bwhiizialy1qfvm3gk2fn9r499n-nss-mdns
FAIL: /gnu/store/csxh0dnpbjqc8q1qkb9j5gbjrlhbpy7v-dicod
FAIL: /gnu/store/6vp4xg0zzrcz5ksdykd9zr5ydwpvjgvk-btrfs-root-os
FAIL: /gnu/store/5lw5gfvljp3kkf32k71g2vik258g9jpj-raid-root-os
FAIL: /gnu/store/n5dq0nx8vgw6ci6wpl7r78bchfs29lfc-installed-os
FAIL: /gnu/store/bm6n23mp1x74jj57kvy2hlfhi2iyxjhs-encrypted-root-os
FAIL: /gnu/store/3sjjq1xavrvhkbj7hqbjgvmcmpagmcpz-installed-extlinux-os
FAIL: /gnu/store/0mj78x3awxwrrjp9s53xgcaa1y5aps8k-separate-store-os
FAIL: /gnu/store/64wmjlfidh0mzl700zfqmrxmc475vhbk-separate-home-os
FAIL: /gnu/store/xrbg9b6xc1q26byw0pxi0lk7q58p3z52-exim-test
make: *** [Makefile:5188: check-system] Error 1

(At the same time, my normal internet connection works fine)