From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: Installer, ISO9660, etc. Date: Fri, 7 Jul 2017 18:13:15 +0200 Message-ID: <20170707181315.2f998f1d@scratchpost.org> References: <20170627221608.A23B52013B@smtp.hushmail.com> <20170628154943.36021286@scratchpost.org> <20170705152024.4dfde1c5@scratchpost.org> <87mv8gbhur.fsf_-_@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTVsv-0001eI-Ry for guix-devel@gnu.org; Fri, 07 Jul 2017 12:13:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTVsr-0006KT-Tl for guix-devel@gnu.org; Fri, 07 Jul 2017 12:13:37 -0400 In-Reply-To: <87mv8gbhur.fsf_-_@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org Hi Ludo, On Fri, 07 Jul 2017 13:34:52 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Danny Milosavljevic skribis: >=20 > > 95% done. If would actually work if we came to a consensus about the v= olume label (it must be uppercase; see bug# 27520 in guix-patches). Also, = UUID boot support is still mostly missing - same as in the non-iso9660 case= . =20 >I hope I=E2=80=99m not holding anything back in this area! Oh, not at all. I'm just not clear on which way we chose (if any?). What was the string-upcase solution? Even if it's created with (string-upc= ase "GuixSD") (and it is - if you don't override it) the boot code as it is= now will still fail to find the root - because it matches labels case-sens= itively. The string-upcase is buried deep within the image creation proced= ure. Or do you mean I should put (string-upcase "GuixSD") in system-disk-image i= n gnu/system/vm.scm as well ? That would work, I guess... although the fini= shed image (iso9660 or not!) would still have "GUIXSD" then. I don't see t= hat as a big deal, though :) There's still the following places: ./gnu/build/vm.scm: search --set=3Droot --label gnu-disk= -image~@ ./gnu/system/install.scm: (device "gnu-disk-image") ./gnu/system/vm.scm: "gnu-disk-image") Or do you mean we should just match case-insensitively in gnu/build/file-sy= stems.scm ? I.e. use (define partition-label-predicate (partition-predicate read-partition-label string-ci=3D?)) That would mean match case-insensitively for both iso9660 and non-iso9660. = I would very much prefer this fix. Whatever it is, we should just pick a way, any way :) Now Hydra is building a 1 GB iso9660 image that won't boot. I've pushed bug# 27521 so "iso9660-image" will now heed the root-label (fro= m system-disk-image) just like the other filesystems do - and then uppercas= e it. That finishes the creation part. Now the booting part... how? :)