bug#27567: netpbm is not reproducible

bug#27567: netpbm is not reproducible

[Danny Milosavljevic]

bug#27567: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.

[Danny Milosavljevic]

* gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
---
 gnu/packages/netpbm.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
index cd0c3d950..6b97d7e06 100644
--- a/gnu/packages/netpbm.scm
+++ b/gnu/packages/netpbm.scm
@@ -109,6 +109,11 @@
    (arguments
     `(#:phases
       (modify-phases %standard-phases
+       (add-after 'unpack 'patch-timestamps
+         (lambda _
+           (substitute* "buildtools/makepointerman"
+             (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
+           #t))
        (replace 'configure
          (lambda* (#:key inputs outputs #:allow-other-keys)
            (copy-file "config.mk.in" "config.mk")

bug#27567: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

On Mon, Jul 03, 2017 at 09:08:01PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
> ---
>  gnu/packages/netpbm.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
> index cd0c3d950..6b97d7e06 100644
> --- a/gnu/packages/netpbm.scm
> +++ b/gnu/packages/netpbm.scm
> @@ -109,6 +109,11 @@
>     (arguments
>      `(#:phases
>        (modify-phases %standard-phases
> +       (add-after 'unpack 'patch-timestamps
> +         (lambda _
> +           (substitute* "buildtools/makepointerman"
> +             (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
> +           #t))

Why this particular date instead of the Unix epoch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27567: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.

[Danny Milosavljevic]

Hi Leo,

On Tue, 4 Jul 2017 15:01:56 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Mon, Jul 03, 2017 at 09:08:01PM +0200, Danny Milosavljevic wrote:
> > * gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
> > ---
> > +             (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
> > +           #t))  
> 
> Why this particular date instead of the Unix epoch?

Copy & paste from example. We can use the Unix epoch as well :)

bug#27567: [PATCH v2] gnu: netpbm: Remove timestamps.

[Danny Milosavljevic]

* gnu/packages/netpbm.scm (netpbm)[source]: Remove timestamps.
---
 gnu/packages/netpbm.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
index cd0c3d950..652c23aed 100644
--- a/gnu/packages/netpbm.scm
+++ b/gnu/packages/netpbm.scm
@@ -87,6 +87,9 @@
                 (drop "ppmtopjxl" in "converter/ppm")
 
                 ;; Remove timestamps from the generated code.
+                (substitute* "buildtools/makepointerman"
+                  (("gmctime[(][)]")
+                   "\"Thu Jan 1 00:00:00 1970\""))
                 (substitute* "buildtools/stamp-date"
                   (("^DATE=.*")
                    "DATE=\"Thu Jan 01 00:00:00+0000 1970\"\n")

bug#27567: [PATCH v2] gnu: netpbm: Remove timestamps.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On Mon, Jul 03, 2017 at 09:16:38PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/netpbm.scm (netpbm)[source]: Remove timestamps.
> ---
>  gnu/packages/netpbm.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
> index cd0c3d950..652c23aed 100644
> --- a/gnu/packages/netpbm.scm
> +++ b/gnu/packages/netpbm.scm
> @@ -87,6 +87,9 @@
>                  (drop "ppmtopjxl" in "converter/ppm")
>  
>                  ;; Remove timestamps from the generated code.
> +                (substitute* "buildtools/makepointerman"
> +                  (("gmctime[(][)]")
> +                   "\"Thu Jan 1 00:00:00 1970\""))

I'm not sure what's going on with core-updates: the last evaluation was
aborted.

So, assuming that you can build groff on core-updates with this change
before Hydra builds netpbm on core-updates, LGTM. Once we build
core-updates to that point, we should wait for the next core-updates
cycle.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]