From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: PATCH in need for discussion: vim-build-system Date: Sun, 2 Jul 2017 19:19:51 +0000 Message-ID: <20170702191951.aaueapwc6fzzlhro@abyayala> References: <20170702161926.yuvhmb52rqyymnmj@abyayala> <20170702190337.GC2938@macbook42.flashner.co.il> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hl6sya3q3g6j5car" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRkPc-0004nu-Qh for guix-devel@gnu.org; Sun, 02 Jul 2017 15:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRkPZ-0008Mx-K9 for guix-devel@gnu.org; Sun, 02 Jul 2017 15:20:04 -0400 Received: from aibo.runbox.com ([91.220.196.211]:46428) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRkPZ-0008LO-8n for guix-devel@gnu.org; Sun, 02 Jul 2017 15:20:01 -0400 Content-Disposition: inline In-Reply-To: <20170702190337.GC2938@macbook42.flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org --hl6sya3q3g6j5car Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Efraim Flashner transcribed 18K bytes: > On Sun, Jul 02, 2017 at 04:19:26PM +0000, ng0 wrote: > > The appended two patches fail, for a reason which is not apparent > > to me (and no reason I could capture). > >=20 > > This is mostly based on the font-build-system with some additions, > > it's more or less the same except for the unpack and install phases. > > --=20 > > ng0 > > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 > > GnuPG: https://n0is.noblogs.org/my-keys > > https://www.infotropique.org https://krosos.org >=20 > > From 9490336916ce4517c64875cc470ccadfad4a27ba Mon Sep 17 00:00:00 2001 > > From: ng0 > > Date: Sun, 2 Jul 2017 16:07:48 +0000 > > Subject: [PATCH 1/2] build-system: Add 'vim-build-system'. > >=20 > > * Makefile.am (MODULES): Add 'guix/build-system/vim.scm' and > > 'guix/build/vim-build-system.scm'. > > * guix/build-system/vim.scm: New file. > > * guix/build/vim-build-system.scm: New file. >=20 > I couldn't get it to build, but here's the changes I made >=20 >=20 > --=20 > Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > Confidentiality cannot be guaranteed on emails sent or received unencrypt= ed > diff --git a/guix/build-system/vim.scm b/guix/build-system/vim.scm > index 6c074fd60..adc0a9fdd 100644 > --- a/guix/build-system/vim.scm > +++ b/guix/build-system/vim.scm > @@ -35,7 +35,7 @@ > ;; Code: > =20 > (define %vim-build-system-modules > - ;; Build-side moduels imported by default. > + ;; Build-side modules imported by default. > `((guix build vim-build-system) > ,@%gnu-build-system-modules)) > =20 > diff --git a/guix/build/vim-build-system.scm b/guix/build/vim-build-syste= m.scm > index 5c55f1256..d97d44cf9 100644 > --- a/guix/build/vim-build-system.scm > +++ b/guix/build/vim-build-system.scm > @@ -49,33 +49,37 @@ archive, a directory or a '.vim' file." > (let* ((out (assoc-ref outputs "out")) > (source (getcwd)) > (vimfiles (string-append out "/share/vim/vimfiles"))) > - (when (file-exists? "autoload") > - (copy-recursively "autoload" > - (string-append vimfiles "/autoload"))) > - (when (file-exists? "afer") > - (copy-recursively "after" > - (string-append vimfiles "/after"))) > - (when (file-exists? "doc") > - (copy-recursively "doc" > - (string-append vimfiles "/doc"))) > - (when (file-exists? "ftdetect") > - (copy-recursively "ftdetect" > - (string-append vimfiles "/ftdetect"))) > - (when (file-exists? "ftplugin") > - (copy-recursively "ftplugin" > - (string-append vimfiles "/ftplugin"))) > - (when (file-exists? "indent") > - (copy-recursively "indent" > - (string-append vimfiles "/indent"))) > - (when (file-exists? "plugin") > - (copy-recursively "plugin" > - (string-append vimfiles "/plugin"))) > - (when (file-exists? "rplugin") > - (copy-recursively "rplugin" > - (string-append vimfiles "/rplugin"))) > - (when (file-exists? "syntax") > - (copy-recursively "syntax" > - (string-append vimfiles "/syntax"))) > + (lambda (dir) > + (when (file-exists? dir) > + (copy-recursively dir (string-append vimfiles "/" dir)))) > + (list "autoload" "after" "doc" "ftdetect" "ftplugin" "indent" "plugi= n" "rplugin" "syntax") > + ;(when (file-exists? "autoload") > + ; (copy-recursively "autoload" > + ; (string-append vimfiles "/autoload"))) > + ;(when (file-exists? "after") > + ; (copy-recursively "after" > + ; (string-append vimfiles "/after"))) > + ;(when (file-exists? "doc") > + ; (copy-recursively "doc" > + ; (string-append vimfiles "/doc"))) > + ;(when (file-exists? "ftdetect") > + ; (copy-recursively "ftdetect" > + ; (string-append vimfiles "/ftdetect"))) > + ;(when (file-exists? "ftplugin") > + ; (copy-recursively "ftplugin" > + ; (string-append vimfiles "/ftplugin"))) > + ;(when (file-exists? "indent") > + ; (copy-recursively "indent" > + ; (string-append vimfiles "/indent"))) > + ;(when (file-exists? "plugin") > + ; (copy-recursively "plugin" > + ; (string-append vimfiles "/plugin"))) > + ;(when (file-exists? "rplugin") > + ; (copy-recursively "rplugin" > + ; (string-append vimfiles "/rplugin"))) > + ;(when (file-exists? "syntax") > + ; (copy-recursively "syntax" > + ; (string-append vimfiles "/syntax"))) > #t)) > =20 > (define %standard-phases I think I will merge this into my patch, it's much a much more compact way to express what I wanted. Ideally we could define an "excludes" list and copy everything else over to the output, as that's how vim packages work. --=20 ng0 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://n0is.noblogs.org/my-keys https://www.infotropique.org https://krosos.org --hl6sya3q3g6j5car Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAllZR1cACgkQ4i+bv+40 hYgInRAApR71idtUW6rsbBCN1YzZYh34Im3RQvOYAL879FU0ufe07/h0yLZWvojT X4tHeqBV5eG7pOK4eGGMV5TbYyjYsNYvST5k9PRGMdOiXrEjyOxMEAlyKyBany53 QOU1FtsMhQFlmFXDR0yZGzY0BzQ8W/KxHPH4wkTE+v+uBL2QzbutoJQEVrxtohY0 1W0WS62heq/3CeKHxwpW/DRhc06zHIQmQhai2gF7EW6hnvlu4jZwSrm/5LazDBDS ChuCTx44pBJPvmlJwju/NSGes/GlJ0UUicpygNVoIWCf+FXzEF9+Tbsc+Z4x0/3A JyTEGwB2ripkbxDa0NWvLc/gxake0zjNva0Ga+0erNyh0Mz8N83DdsI65PyrpeY5 l91BtGLi0CkioIjkn1Ov6CE/7U1GIjBw3p56jBtEOG1CNT5NjMaafNGMxK+/bZn7 psgtL1Da10+Vp3MQpM9PJNCUZggh9vKAhZd51g29nPeRxzSkhSLPK5tC7EB9IDXa eW3ckAyv4/N4qHE9Pjd+YOBUpHeSykF8VZkY14d4DxLGwni+Jw8K4ggJtS5MNHd2 eLXSOblcf2wmeix2wldtfVMMAlS+L6lPLG/shtL3YGu6gomXfvQCvLPdeHsxVNph rpLpz07m3V9d7crU663wBfDY6x7c6V9WPqhubLnzdEjfrEaDd/k= =7VfH -----END PGP SIGNATURE----- --hl6sya3q3g6j5car--