From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dRbmT-00088T-SJ
	for guix-patches@gnu.org; Sun, 02 Jul 2017 06:07:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dRbmQ-0001LW-M9
	for guix-patches@gnu.org; Sun, 02 Jul 2017 06:07:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45499)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dRbmQ-0001LL-IN
	for guix-patches@gnu.org; Sun, 02 Jul 2017 06:07:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dRbmQ-0004oh-6A
	for guix-patches@gnu.org; Sun, 02 Jul 2017 06:07:02 -0400
Subject: [bug#27520] [PATCH] build: Use "GUIXSD" as root label.
Resent-Message-ID: <handler.27520.B27520.149898996518451@debbugs.gnu.org>
Date: Sun, 2 Jul 2017 12:05:57 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170702120557.07355db9@scratchpost.org>
In-Reply-To: <878tkalqdg.fsf@gnu.org>
References: <20170628213841.28774-1-dannym@scratchpost.org>
	<20170628220117.GA15943@jasmine.lan>
	<20170629001701.26b5f427@scratchpost.org>
	<20170628224709.GA30324@jasmine.lan>
	<20170629015414.521e7f0c@scratchpost.org> <878tkalqdg.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27520@debbugs.gnu.org

Hi Ludo,

On Thu, 29 Jun 2017 18:18:03 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> So what about literally =E2=80=9CGuixSD=E2=80=9D and then using =E2=80=98=
string-upcase=E2=80=99 in the
> ISO9660 code?  That would avoid the all-caps style on all the other file
> systems, which is a good thing.

As the code is written, it would be best and least confusing if gnu/build/f=
ile-systems.scm partition-label-predicate then just said

(define partition-label-predicate
  (partition-predicate read-partition-label string-ci=3D?))

instead of

(define partition-label-predicate
  (partition-predicate read-partition-label string=3D?))

, i.e. if it was done for all the filesystems.

Other alternatives are
- Implementing support for the Joliet extension just to get get lowercase l=
etters on CDs
- Ignoring the problem and putting the lowercase letters in the primary vol=
ume name on CD anyway, using ISO-9660.  After all it's just forbidden, not =
impossible.

I personally favor just actually using all uppercase letters as the label. =
 Everything else makes it just needlessly complicated.

That said, the right fix would be to use the UUID instead of the label for =
finding the root filesystem.  Using the label isn't really safe anyway - wh=
ereas a random UUID should be preeeeeeetty safe.

I'm testing passing the UUID now.  Let's see...