From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP7qd-0004TZ-A8 for guix-patches@gnu.org; Sun, 25 Jun 2017 09:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP7qZ-0005dA-6m for guix-patches@gnu.org; Sun, 25 Jun 2017 09:45:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33752) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dP7qZ-0005cw-2N for guix-patches@gnu.org; Sun, 25 Jun 2017 09:45:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dP7qY-0005vt-LP for guix-patches@gnu.org; Sun, 25 Jun 2017 09:45:02 -0400 Subject: [bug#27434] [PATCH] gnu: Add mkvtoolnix. Resent-Message-ID: Date: Sun, 25 Jun 2017 09:44:01 -0400 From: Leo Famulari Message-ID: <20170625134401.GA7385@jasmine.lan> References: <20170620215432.h6ed3xyci2gcecz2@zaehlwerk.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20170620215432.h6ed3xyci2gcecz2@zaehlwerk.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Gregor Giesen Cc: 27434@debbugs.gnu.org --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 20, 2017 at 11:54:33PM +0200, Gregor Giesen wrote: > * gnu/packages/serialization.scm (nlohmann-json-cpp): New variable. > * gnu/packages/video.scm (mkvtoolnix libmatroska): New variables. > * gnu/packages/xml.scm (libebml): New variable. Thank you! I spent some time splitting this patch into "one patch per package", which is how we like to do it. nlohmnann-json-cpp, libebml, and libmatroska are done, in my opinion, and I'll push them shortly. > +(define-public mkvtoolnix > + (package > + (name "mkvtoolnix") > + (version "12.0.0") When I built and ran mkvtoolnix-gui, it told me there was a new version available (13.0.0). Can we use that version instead? > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://mkvtoolnix.download/sources/" > + name "-" version ".tar.xz")) I noticed it includes some files in 'lib/', and at least some of them appear to be bundled copies of 3rd-party libraries: $ ls -l mkvtoolnix-12.0.0/lib total 4 drwxr-xr-x 1 leo leo 116 May 20 13:25 avilib-0.6.10 drwxr-xr-x 1 leo leo 66 May 20 13:25 boost drwxr-xr-x 1 leo leo 194 May 20 13:25 libebml drwxr-xr-x 1 leo leo 236 May 20 13:25 libmatroska drwxr-xr-x 1 leo leo 120 May 20 13:25 librmff drwxr-xr-x 1 leo leo 70 May 20 13:25 nlohmann-json drwxr-xr-x 1 leo leo 26 May 20 13:25 pugixml -rw-r--r-- 1 leo leo 244 May 20 13:25 Rakefile drwxr-xr-x 1 leo leo 18 May 20 13:25 utf8-cpp After removing libebml, libmatroska, and nlohmann-json in an "origin snippet" [0], mkvtoolnix still builds. We don't like to use or distribute bundled libraries if we can help it. I didn't have time yet to investigate the other directories in that list. > + (native-inputs > + `(("docbook-xsl" ,docbook-xsl) > + ("gettext" ,gettext-minimal) > + ("googletest" ,googletest) > + ("libxslt" ,libxslt) > + ("nlohmann-json-cpp" ,nlohmann-json-cpp) > + ("perl" ,perl) > + ("pkg-config" ,pkg-config) > + ("po4a" ,po4a) > + ("ruby" ,ruby) > + ("zsh", zsh))) Does it need to use Zsh while building? Native-inputs are basically build-time dependencies, and it's definitely unusual to require Zsh, so that's why I'm asking. I removed Zsh from this list and the resulting mkvtoolnix-gui seems to start without any problems. --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAllPvgwACgkQJkb6MLrK fwjsFRAAiWDllL4xYP2U0Bx7XxNBlKvlwC7EIpuwnyoGE91brvyBcuPGJ0VeM1W1 tMh1rfIbadlTcnmqWSC9QTKkWQ0xpI+fpIXXGcaojJ5f04e+7VReYf/Vacvxd8WJ nmsFkIuV0FL6szPvrVuX1RX5AoryWdFSPgCPqnOoXXojf+yhhTyznOPRxOwINNWc /ho8tiPw83YvjceLmLI80m7JXww6qRSRSlw2Y9iD1UHhMN1Q/v2d4kJV8DhI1DQO 5CGhejYETo7BQldoTjcRZHk/E0MpqFdnO2DpCMb7b+JsxIlz4v23nYtzMXQDy9H5 j1Nd+vQkdkqAqDWBnPEfmoXWeuUET8fISFuLqv8RBqKSukLH0nPVJN7W38+ChYts KRMuJnGurJDD/UME10nzep9SKWEfJqCWy6d/s2UA9YfxN9RfqFIxJegF8d1ZktI6 +48q7u/eGFYiGHXXCRnpgUgjGeyS7Q9Fz0x2WeoOpmgK2xIk2ejUHbR7EHkPf/ds vNPxBrFWxUHF2TCgND73zHp4M+FRrKSxO8q20V4BjonXfGxcHCDyPWPY9GGCKV/e 2tSZuE0Ahaphfh0mCElnVhZ4edYUL96FEaI/dwodczu+a7QU6Mpik3VZ7/YPSQDJ 1x1CuZ+l4EZyXesRu0VKrSBLz9nFD9Mo7teh+FCJsRwzwBQUG+E= =I7OO -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--