From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: bug#26936: grub_cmd_set_date test sometimes fail Date: Sat, 24 Jun 2017 13:19:25 -0400 Message-ID: <20170624171925.GA9251@jasmine.lan> References: <87vap2iqc5.fsf@gmail.com> <871sr2ngp5.fsf@inria.fr> <20170623193010.GA23820@jasmine.lan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOoj9-0005lb-AG for bug-guix@gnu.org; Sat, 24 Jun 2017 13:20:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOoj4-000640-Gv for bug-guix@gnu.org; Sat, 24 Jun 2017 13:20:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dOoj4-00063A-0Q for bug-guix@gnu.org; Sat, 24 Jun 2017 13:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dOoj3-0005cg-KC for bug-guix@gnu.org; Sat, 24 Jun 2017 13:20:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20170623193010.GA23820@jasmine.lan> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 26936@debbugs.gnu.org --b5gNqxB1S1yM7hjW Content-Type: multipart/mixed; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 23, 2017 at 03:30:10PM -0400, Leo Famulari wrote: > On Sat, Jun 03, 2017 at 12:54:46AM +0200, Ludovic Court=C3=A8s wrote: > > FAIL: grub_cmd_set_date >=20 > > All in all, I=E2=80=99m tempted to think this has to do with running th= e tests > > in parallel. > >=20 > > As a stop-gap measure, I=E2=80=99ve committed a change to run tests > > sequentially. With this =E2=80=9Cguix build grub --rounds=3D5=E2=80=9D= passes for on my > > x86_64 laptop. Let=E2=80=99s reopen the bug if we find that=E2=80=99s = not enough. >=20 > This test just failed for me on x86_64, even with #:parallel-tests? #f. >=20 > So, perhaps it's not an inter-test race, or perhaps the tests are still > running in parallel, or some other thing. Spurred by another report of this test failing, here's a patch to disable it completely. --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-grub-Disable-a-flaky-test.patch" Content-Transfer-Encoding: quoted-printable =46rom 71299a035f793c3e2ac723b326cd881e97df6274 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Sat, 24 Jun 2017 13:17:37 -0400 Subject: [PATCH] gnu: grub: Disable a flaky test. * gnu/packages/bootloaders.scm (grub)[arguments]: Add 'disable-flaky-test' = phase and run the tests in parallel. --- gnu/packages/bootloaders.scm | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index dec462b0c..9ae617528 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -91,11 +91,15 @@ ;; Make the font visible. (copy-file (assoc-ref inputs "unifont") "unifont.bdf.= gz") (system* "gunzip" "unifont.bdf.gz") - #t))) - - ;; We suspect there are race conditions when running tests in paral= lel: - ;; . - #:parallel-tests? #f)) + #t)) + (add-before 'check 'disable-flaky-test + (lambda _ + ;; This test is unreliable. For more information, se= e: + ;; . + (substitute* "Makefile.in" + (("grub_cmd_date grub_cmd_set_date grub_cmd_sleep") + "grub_cmd_date grub_cmd_sleep")) + #t))))) (inputs `(("gettext" ,gettext-minimal) =20 --=20 2.13.1 --G4iJoqBmSsgzjUCe-- --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAllOnx0ACgkQJkb6MLrK fwgg8g//aniz5QbalysskSPV6Cs7kir8S1tj0NakJ1icH6HNcC77jX2sVRd47vyx 84pEvLLloRZFF9bUT0Gf85NovVcqbcLLvaima+m3Wv1RjpK/eiFOWfphgrC/IqlV 7w5+WHRscj8IK2sOMInzl5kE6ey7ve7jdouXeJ+TlfedTFr9Y9/1RZq2Axu3bbZL ryNQgIneyBZ7Fx1eONtnE4nDoMBadDIBU0CrrUMffBSI9mbMVcKu+B5hVxZUSZrp xDvkGwgJGwJzoJxEIUgENHk6LDFRGfbvfi2+21/41A01v1jZNrP4uEm3doEZ4Lba A9VKfZs+2FTLyfOHU8xVgDhma+8sYsG69nrTmwhdz6V5KkJi9+b56Y+9HU1O/W0i DpP34HPL1y69m6zjc8xLwGTrXCbuWXx1vqCmER5QzJvLprdeHUiohNRe7RlXdn3d 7i79sGjy83A3HVNH9Z5zK9EmlUzYQAhIVdt1sh42DURPQ/K0oKd/7tj1L1Xxw6VR 5ursUKNYf4R3B0oVR4ImXZuw1QDKqZmpokqCTjcmCYDWMUNJsmTWDGi5jk8J30Ep Y+bUUUClBWRntw0xnZqubM6x5mxjdyk8wdVCWUS9mMoRt1lvK4j8v/SCTUgswm50 +AqtL34W8XWQ++D/MARjNuSt4IEABqhOO3M1h6jUzr9UOagwHWU= =nUtO -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW--