From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dN3P3-0001hA-RR
	for guix-patches@gnu.org; Mon, 19 Jun 2017 16:36:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dN3P0-0007Dl-L0
	for guix-patches@gnu.org; Mon, 19 Jun 2017 16:36:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53930)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dN3P0-0007Df-Gn
	for guix-patches@gnu.org; Mon, 19 Jun 2017 16:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dN3P0-0003dH-Ag
	for guix-patches@gnu.org; Mon, 19 Jun 2017 16:36:02 -0400
Subject: [bug#27355] [PATCH 5/7] gnu: Add libsigrok.
Resent-Message-ID: <handler.27355.B27355.149790451713910@debbugs.gnu.org>
Date: Mon, 19 Jun 2017 22:35:09 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170619223509.08a92d51@scratchpost.org>
In-Reply-To: <20170614095813.1926-5-theodoros.for@openmailbox.org>
References: <20170614095813.1926-1-theodoros.for@openmailbox.org>
	<20170614095813.1926-5-theodoros.for@openmailbox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: 27355@debbugs.gnu.org

Hi,

On Wed, 14 Jun 2017 12:58:11 +0300
Theodoros Foradis <theodoros.for@openmailbox.org> wrote:

> +     `(#:tests? #f ; tests need usb access

All of them?

> +         (add-after 'install 'install-udev-rules
...
> +         (add-after 'install-eudev-rules 'install-fw
                                ^ e?

> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((fx2lafw (assoc-ref inputs "sigrok-firmware-fx2lafw"))
> +                    (out (assoc-ref outputs "out"))
> +                    (dir "/share/sigrok-firmware/")

Maybe "dir-suffix" ?  Not that important...

> +    (description "Libsigrok is a shared library written in C, which provides the basic hardware

                                                               ^ comma looks weird here

Also maybe @code{libsigrok} ?

Otherwise LGTM!