bug#27002: [PATCH] gnu: Add lollypop.

bug#27002: [PATCH] gnu: Add lollypop.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 74 bytes --]

Hello,
Lollypop is a modern and intuitive music player.
Lint and tested.

[-- Attachment #2: 0001-gnu-Add-lollypop.patch --]
[-- Type: text/x-patch, Size: 4580 bytes --]

From 7a7e30d3d11002e0ff693a8684f6fb33ea464b6d Mon Sep 17 00:00:00 2001
From: rennes <rennes@openmailbox.org>
Date: Fri, 19 May 2017 23:11:38 -0500
Subject: [PATCH] gnu: Add lollypop.

* guix/gnu/packages/mpd.scm (lollypop): New variable.
---
 gnu/packages/mpd.scm | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 1ed8e967e..6aeaf8897 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2017 Rene Saavedra <rennes@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -27,6 +28,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
   #:use-module (gnu packages avahi)
@@ -34,6 +36,7 @@
   #:use-module (gnu packages gcc) ; GCC@5 for MPD >= 0.20
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages readline)
@@ -43,12 +46,14 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages mp3)
+  #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages webkit)
   #:use-module (gnu packages xiph))
 
 (define-public libmpdclient
@@ -323,3 +328,57 @@ Daemon (MPD).  It supports playlists, multiple profiles (connecting to different
 MPD servers, search and multimedia key support.")
     (home-page "http://www.nongnu.org/sonata/")
     (license license:gpl3+)))
+
+(define-public lollypop
+  (package
+    (name "lollypop")
+    (version "0.9.237")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/gnumdk/lollypop/"
+                           "releases/download/" version "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "027m5px4hsri7bnzn147l0kx7fam57sw93pwkv84pymcxh87f7s6"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     `(#:imported-modules ((guix build python-build-system)
+                           ,@%glib-or-gtk-build-system-modules)
+       #:phases (modify-phases %standard-phases
+                  (add-after 'install 'wrap-program
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out               (assoc-ref outputs "out"))
+                            (gi-typelib-path   (getenv "GI_TYPELIB_PATH")))
+                        (wrap-program (string-append out "/bin/lollypop")
+                          `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
+                      #t))
+                  (add-after 'install 'wrap
+                    (@@ (guix build python-build-system) wrap)))))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gobject-introspection" ,gobject-introspection)
+       ("gtk+" ,gtk+)
+       ("libnotify" ,libnotify)
+       ("libsecret" ,libsecret)
+       ("libsoup" ,libsoup)
+       ("python" ,python)
+       ("python-beautifulsoup4" ,python-beautifulsoup4)
+       ("python-gst" ,python-gst)
+       ("python-pycairo" ,python-pycairo)
+       ("python-pygobject" ,python-pygobject)
+       ("python-pylast" ,python-pylast)
+       ("totem-pl-parser" ,totem-pl-parser)
+       ("webkitgtk" ,webkitgtk)))
+    (home-page "https://gnumdk.github.io/lollypop-web")
+    (synopsis "GNOME music playing application")
+    (description
+     "Lollypop is a music player designed to play well with GNOME desktop.
+Lollypop plays audio formats such as mp3, mp4, ogg and flac and gets information
+from artists and tracks from the web.  It also fetches cover artworks
+automatically and it can stream songs from online music services and charts.")
+    (license license:gpl3+)))
-- 
2.12.0

[bug#27002] [PATCH] gnu: Add lollypop.

[Thomas Danckaert]

rennes <rennes@openmailbox.org> writes:

> Hello,
> Lollypop is a modern and intuitive music player.
> Lint and tested.

Hi,

looks good to me, though the recent update of the gmime package (commit
a512ca81e) breaks the totem-pl-parser package, so lollypop doesn't build
on current guix master.

I tested it on the commit before the gmime update (f54efbdc4), and was
able to build it, but the program would not run.  Something about a
gstreamer issue, though I have the gst-plugins-xyz packages in my
profile.

(lollypop:16613): GStreamer-CRITICAL **: gst_bin_add: assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:16613): GStreamer-CRITICAL **: gst_element_get_static_pad: assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:16613): GStreamer-CRITICAL **: gst_object_unref: assertion 'object != NULL' failed
Replay Gain not available,

Is there anything I should do to make this work, or are there extra
variables that should be set when wrapping the executable?

I also noticed that the executable gets wrapped twice: bin/lollypop
wraps bin/.lollypop-real, which wraps bin/..lollypop-real-real :-) Can
this be avoided, or is it a side-effect of using the python build system
and wrapping the result?

Thomas

[bug#27002] [PATCH] gnu: Add lollypop.

[Ludovic Courtès]

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> I also noticed that the executable gets wrapped twice: bin/lollypop
> wraps bin/.lollypop-real, which wraps bin/..lollypop-real-real :-) Can
> this be avoided, or is it a side-effect of using the python build system
> and wrapping the result?

The ‘wrap-program’ procedure in (guix build utils) arranges things so as
to never create double wrappers, so it would be interesting to see how
this happened!

Ludo’.

[bug#27002] [PATCH] gnu: Add lollypop.

[rennes]

Hello,
thank you for your comments.

I had not noticed that in my profile I have installed  
'gst-plugins-base'. I try to add 'gst-plugins-base' to Inputs but it  
does not work, I will continue to test.

On the other hand, under the 'bin' directory I only see one binary for  
lollipop:

jin@home ~$ l  
/gnu/store/0psmp896kkijsszczmvbs0b9h7wfprdb-lollypop-0.9.240/bin/
total 12
-r-xr-xr-x 2 root root 2743 Dec 31  1969 lollypop
-r-xr-xr-x 2 root root 1523 Dec 31  1969 lollypop-cli
-r-xr-xr-x 2 root root 1529 Dec 31  1969 rhythmbox2lollypop


On 06/16/2017 07:59:39 AM, Ludovic Courtès wrote:
> Thomas Danckaert <post@thomasdanckaert.be> skribis:
> 
> > I also noticed that the executable gets wrapped twice: bin/lollypop
> > wraps bin/.lollypop-real, which wraps bin/..lollypop-real-real :-)  
> Can
> > this be avoided, or is it a side-effect of using the python build  
> system
> > and wrapping the result?
> 
> The ‘wrap-program’ procedure in (guix build utils) arranges things so  
> as
> to never create double wrappers, so it would be interesting to see how
> this happened!

[bug#27002] [PATCH] gnu: Add lollypop.

[Thomas Danckaert]

From: rennes <rennes@openmailbox.org>
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Sat, 17 Jun 2017 22:21:28 -0500

> I had not noticed that in my profile I have installed
> 'gst-plugins-base'. I try to add 'gst-plugins-base' to Inputs but it
> does not work, I will continue to test.

I also have gst-plugins-base in my profile.  I don't know why it 
doesn't work :)  I assume lollypop works for you?

> On the other hand, under the 'bin' directory I only see one binary 
> for
> lollipop:

Try "ll -a" to show the “hidden” files.

thanks,

Thomas

[bug#27002] [PATCH] gnu: Add lollypop.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hello,
> 
> I also have gst-plugins-base in my profile.  I don't know why it  
> doesn't work :)  I assume lollypop works for you?
> 
I have added libraries to 'propagated-inputs', in 'inputs' does not  
work.
Now I don't have libraries in my profile. Can you test?

[-- Attachment #2: 0001-gnu-Add-lollypop.patch --]
[-- Type: text/x-patch, Size: 4866 bytes --]

From 53cb8073b21fbdcebdb83e3030344bfc38541bb9 Mon Sep 17 00:00:00 2001
From: rennes <rennes@openmailbox.org>
Date: Sat, 24 Jun 2017 12:53:16 -0500
Subject: [PATCH] gnu: Add lollypop.

* guix/gnu/packages/mpd.scm (lollypop): New variable.
---
 gnu/packages/mpd.scm | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 5692ff676..a95f516a3 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2017 Rene Saavedra <rennes@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -27,6 +28,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
   #:use-module (gnu packages avahi)
@@ -34,6 +36,7 @@
   #:use-module (gnu packages gcc) ; GCC@5 for MPD >= 0.20
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages readline)
@@ -43,12 +46,14 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages mp3)
+  #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages webkit)
   #:use-module (gnu packages xiph))
 
 (define-public libmpdclient
@@ -322,3 +327,63 @@ Daemon (MPD).  It supports playlists, multiple profiles (connecting to different
 MPD servers, search and multimedia key support.")
     (home-page "http://www.nongnu.org/sonata/")
     (license license:gpl3+)))
+
+(define-public lollypop
+  (package
+    (name "lollypop")
+    (version "0.9.240")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/gnumdk/lollypop/"
+                           "releases/download/" version "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0n1ycmg6dgz1pajs80fwlcbxw3rx1hff1xw6ja67zngm85ydbjvq"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     `(#:imported-modules ((guix build python-build-system)
+                           ,@%glib-or-gtk-build-system-modules)
+       #:phases (modify-phases %standard-phases
+                  (add-after 'install 'wrap-program
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out               (assoc-ref outputs "out"))
+                            (gi-typelib-path   (getenv "GI_TYPELIB_PATH")))
+                        (wrap-program (string-append out "/bin/lollypop")
+                          `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
+                      #t))
+                  (add-after 'install 'wrap
+                    (@@ (guix build python-build-system) wrap)))))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gobject-introspection" ,gobject-introspection)
+       ("gtk+" ,gtk+)
+       ("libnotify" ,libnotify)
+       ("libsecret" ,libsecret)
+       ("libsoup" ,libsoup)
+       ("python" ,python)
+       ("python-beautifulsoup4" ,python-beautifulsoup4)
+       ("python-gst" ,python-gst)
+       ("python-pycairo" ,python-pycairo)
+       ("python-pygobject" ,python-pygobject)
+       ("python-pylast" ,python-pylast)
+       ("totem-pl-parser" ,totem-pl-parser)
+       ("webkitgtk" ,webkitgtk)))
+    (propagated-inputs
+     `(;; gst-plugins-base is required to start Lollypop,
+       ;; the others are required to play streaming.
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gst-plugins-good" ,gst-plugins-good)
+       ("gst-plugins-ugly" ,gst-plugins-ugly)))
+    (home-page "https://gnumdk.github.io/lollypop-web")
+    (synopsis "GNOME music playing application")
+    (description
+     "Lollypop is a music player designed to play well with GNOME desktop.
+Lollypop plays audio formats such as mp3, mp4, ogg and flac and gets information
+from artists and tracks from the web.  It also fetches cover artworks
+automatically and it can stream songs from online music services and charts.")
+    (license license:gpl3+)))
-- 
2.13.1

[bug#27002] [PATCH] gnu: Add lollypop.

[Thomas Danckaert]

From: rennes <rennes@openmailbox.org>
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Sat, 24 Jun 2017 13:06:53 -0500

>>I also have gst-plugins-base in my profile.  I don't know why it
>>doesn't work :) I assume lollypop works for you?
>>
> I have added libraries to 'propagated-inputs', in 'inputs' does not
> work.
> Now I don't have libraries in my profile. Can you test?

I don't think that was the problem, because I have all the 
gst-plugins-xyz libraries installed, too.  The patch didn't change 
the result.  Perhaps someone else can check and possibly apply this 
patch (perhaps the patch is fine and it's a problem on my system :-/ )

Thomas

For future reference, I'll copy the output I get when I try to run 
'lollypop'.  It looks like something goes wrong with the (py-)gobject 
for gstreamer:

/gnu/store/6jwmm9f665xmkkhhj1x5b904kzn00y82-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178: 
Warning: g_array_append_vals: assertion 'array' failed
   g_type = info.get_g_type()
/gnu/store/6jwmm9f665xmkkhhj1x5b904kzn00y82-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178: 
Warning: g_hash_table_lookup: assertion 'hash_table != NULL' failed
   g_type = info.get_g_type()
/gnu/store/6jwmm9f665xmkkhhj1x5b904kzn00y82-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178: 
Warning: g_hash_table_insert_internal: assertion 'hash_table != NULL' 
failed
   g_type = info.get_g_type()
You need to add a music uri to org.gnome.Lollypop in dconf
/gnu/store/9xik31h3z5vi0kbcg8av5c2h9wqckjs5-python-gst-1.12.0/lib/python3.5/site-packages/gi/overrides/Gst.py:217: 
Warning: g_object_set: assertion 'G_IS_OBJECT (object)' failed
   return Gst.ElementFactory.make(factory_name, instance_name)

(lollypop:29867): GStreamer-CRITICAL **: gst_bin_add: assertion 
'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_element_get_static_pad: 
assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_object_unref: assertion 
'object != NULL' failed
Replay Gain not available,
please check your gstreamer installation...

(lollypop:29867): GStreamer-CRITICAL **: gst_bin_add: assertion 
'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_element_get_static_pad: 
assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_object_unref: assertion 
'object != NULL' failed
Replay Gain not available,
please check your gstreamer installation...
Traceback (most recent call last):
   File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/application.py", 
line 210, in do_startup
     self.init()
   File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/application.py", 
line 169, in init
     self.player = Player()
   File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/player.py", 
line 40, in __init__
     BinPlayer.__init__(self)
   File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/player_bin.py", 
line 46, in __init__
     self._playbin.connect("notify::volume", self.__on_volume_changed)
AttributeError: 'NoneType' object has no attribute 'connect'

bug#27002: [PATCH] gnu: Add lollypop.

[Ludovic Courtès]

Hi,

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> I don't think that was the problem, because I have all the
> gst-plugins-xyz libraries installed, too.  The patch didn't change the
> result.  Perhaps someone else can check and possibly apply this patch
> (perhaps the patch is fine and it's a problem on my system :-/ )

I went ahead and applied this patch since it had been sitting here for a
while already.  I moved it to gnome.scm, which seems more appropriate
than mpd.scm (it’s not an MPD client AIUI).

Apparently it requires a full GNOME desktop to run so I couldn’t test
it.  If you notice something’s wrong, we can always fix it.

Thank you!

Ludo’.

[bug#27002] [PATCH] gnu: Add lollypop.

[Thomas Danckaert]

From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Fri, 16 Jun 2017 14:59:39 +0200

> The ‘wrap-program’ procedure in (guix build utils) arranges things 
> so as
> to never create double wrappers, so it would be interesting to see 
> how
> this happened!

I think it happens as follows: the lollypop package uses three 
wrapping phases:

  - the GI_TYPELIB_PATH wrapping defined in the package description

  - 'wrap' from the python build system

  - 'glib-or-gtk-wrap'

It looks like wrapping methods from different build systems do not 
compose well: both the glib and python wrapping code contain a loop 
over all executables, so they wrap the executables “.xyz-real” from 
previous wrappings, too.  (the wrap-program procedure only checks if 
“.xyz-real” exists, when wrapping “xyz”, but it does not check if 
“xyz” itself is already a wrapper.  One solution (but probably for 
core-updates) might be to exclude wrapper files from the list of 
executables in the python and glib build systems?

Thomas