From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: ld-wrapper and funny bytes in LIBRARY_PATH
Date: Sun, 18 Jun 2017 10:19:35 +0200 [thread overview]
Message-ID: <20170618101935.747c7a22@scratchpost.org> (raw)
In-Reply-To: <87k24a9rx3.fsf@gnu.org>
Hi Ludo,
On Sun, 18 Jun 2017 00:21:28 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
> > so I'm trying to enable Rust tests and one of their tests does the following (paraphrased) in order to exercise the non-UTF8 linker case (which they want to succeed):
> >
> > ----------------------------------------------
> > bad_dir := zzz$$'\xff'
> >
> > all:
> > mkdir $(bad_dir)
> > cp ... $(bad_dir)/liblibrary.a
> > LIBRARY_PATH=$(bad_dir) rustc exec.rs
> > ----------------------------------------------
> >
> > This fails for us.
>
> So they expect ‘ld’ to properly deal with UTF-8 file names, right?
I think they want ld to properly deal with random file names. 0xFF is not even valid UTF-8.
See also:
- https://github.com/rust-lang/rust/issues/29122 (initial bug report)
- https://github.com/rust-lang/rust/pull/29134 (pull request)
- https://github.com/wthrowe/rust/commit/19664fdf8d1b8fc5fd3b359c2440625b2b4d8cec (test)
> This is another instance of the file name decoding problem with Guile.
> As you know, Guile 2.0/2.2 decodes file names according to the current
> locale, and ‘ld-wrapper’ runs Guile.
Sigh...
Well, I've posted a patch to guix-patches that disables the Rust test in question. Can't do much else than that.
The other 15444 Rust tests work now :)
next prev parent reply other threads:[~2017-06-18 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 8:48 ld-wrapper and funny bytes in LIBRARY_PATH Danny Milosavljevic
2017-06-17 22:21 ` Ludovic Courtès
2017-06-18 8:19 ` Danny Milosavljevic [this message]
2017-06-18 9:50 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618101935.747c7a22@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.