From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dLTDy-00030K-LR
	for guix-patches@gnu.org; Thu, 15 Jun 2017 07:46:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dLTDu-0008JM-Fk
	for guix-patches@gnu.org; Thu, 15 Jun 2017 07:46:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45954)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dLTDu-0008J8-7S
	for guix-patches@gnu.org; Thu, 15 Jun 2017 07:46:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dLTDt-0003J5-VB
	for guix-patches@gnu.org; Thu, 15 Jun 2017 07:46:01 -0400
Subject: [bug#27344] [PATCH 08/12] gnu: Add ngspice.
Resent-Message-ID: <handler.27344.B27344.149752714212683@debbugs.gnu.org>
Date: Thu, 15 Jun 2017 13:45:34 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170615134534.1f832b53@scratchpost.org>
In-Reply-To: <20170612165226.1268-8-theodoros.for@openmailbox.org>
References: <20170612165226.1268-1-theodoros.for@openmailbox.org>
	<20170612165226.1268-8-theodoros.for@openmailbox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: 27344@debbugs.gnu.org

> +                   (license:non-copyleft "file://COPYING") ; spice3 bsd-style

This would mean the current directory of the current user on the remote host with name "COPYING".

I think you meant file:///COPYING which refers to the file "COPYING" on localhost.

> +           ((#:phases phases)
> +            `(alist-cons-after 'install 'in-ng

Please use modify-phases.

Please name the phase so that one can know what it does...

> +               (lambda* (#:key inputs outputs #:allow-other-keys)
> +                 (map (lambda (lib)
> +                        (copy-file
> +                         (string-append (assoc-ref inputs "libngspice")
> +                                        "/lib/" lib)
> +                         (string-append (assoc-ref outputs "out")
> +                                        "/lib/" lib)))
> +                      '("libngspice.so.0" "libngspice.so"))

Just use for-each...