bug#27311: Enlightenment: 'cpufreq binary needs suid or has to be owned by root'

bug#27311: Enlightenment: 'cpufreq binary needs suid or has to be owned by root'

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

To reproduce (on an desktop computer):

Add enlightenment to your system config, reconfigure,
reboot, log in and click through the Enlightenment
first start dialogue (which itself reveals more bugs ;))
and the first message box you get after you completed
the first start dialogue and E21 has loaded is this:

Cpufreq Permissions Error

The freqset binary in the cpufreq module
is not owned by root or does not have the
setuid bit set. Please ensure this is the
case. For example:

sudo chown root /gnu/store/aaaaaaaaaaa-enlightenment-0.21.7/lib/enlightenment/modules/cpufreq/linux-gnu-x86_64-ver-0.21/freqset
sudo chmod u+s,a+x /gnu/store/aaaaaaaaaaa-enlightenment-0.21.7/lib/enlightenment/modules/cpufreq/linux-gnu-x86_64-ver-0.21/freqset




It seems like we need to have an 'enlightenment-service' similar to
xfce4 and gnome.

There's a number of dysfunctional features at the moment, I like to
track them all in related or unique bugs.
-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27311: Acknowledgement (Enlightenment: 'cpufreq binary needs suid or has to be owned by root')

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

GNU bug Tracking System transcribed 0.7K bytes:
> Thank you for filing a new bug report with debbugs.gnu.org.
> 
> This is an automatically generated reply to let you know your message
> has been received.
> 
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
> 
> Your message has been sent to the package maintainer(s):
>  bug-guix@gnu.org
> 
> If you wish to submit further information on this problem, please
> send it to 27311@debbugs.gnu.org.
> 
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
> 
> -- 
> 27311: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27311
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>

It seems as if Nix has a solution to some of the problems I encounter
with Enlightenment. I'll try and fix most of the bugs I reported.
-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27311: Acknowledgement (Enlightenment: 'cpufreq binary needs suid or has to be owned by root')

[ng0]

[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]

ng0 transcribed 2.0K bytes:
> GNU bug Tracking System transcribed 0.7K bytes:
> > Thank you for filing a new bug report with debbugs.gnu.org.
> > 
> > This is an automatically generated reply to let you know your message
> > has been received.
> > 
> > Your message is being forwarded to the package maintainers and other
> > interested parties for their attention; they will reply in due course.
> > 
> > Your message has been sent to the package maintainer(s):
> >  bug-guix@gnu.org
> > 
> > If you wish to submit further information on this problem, please
> > send it to 27311@debbugs.gnu.org.
> > 
> > Please do not send mail to help-debbugs@gnu.org unless you wish
> > to report a problem with the Bug-tracking system.
> > 
> > -- 
> > 27311: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27311
> > GNU Bug Tracking System
> > Contact help-debbugs@gnu.org with problems
> >
> 
> It seems as if Nix has a solution to some of the problems I encounter
> with Enlightenment. I'll try and fix most of the bugs I reported.

Nix solved this particular issue (cpufreq) with a hack.
It's okay for me, but do some of you agree with applying this:

  # this is a hack and without this cpufreq module is not working. does the following:
  #   1. moves the "freqset" binary to "e_freqset",
  #   2. linkes "e_freqset" to enlightenment/bin so that,
  #   3. wrappers.setuid detects it and places wrappers in /run/wrappers/bin/e_freqset,
  #   4. and finally, links /run/wrappers/bin/e_freqset to original destination where enlightenment wants it
  postInstall = ''
    export CPUFREQ_DIRPATH=`readlink -f $out/lib/enlightenment/modules/cpufreq/linux-gnu-*`;
    mv $CPUFREQ_DIRPATH/freqset $CPUFREQ_DIRPATH/e_freqset
    ln -sv $CPUFREQ_DIRPATH/e_freqset $out/bin/e_freqset
    ln -sv /run/wrappers/bin/e_freqset $CPUFREQ_DIRPATH/freqset
  '';


source: https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/enlightenment/enlightenment.nix


-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27311: Acknowledgement (Enlightenment: 'cpufreq binary needs suid or has to be owned by root')

[Ricardo Wurmus]

ng0 <ng0@pragmatique.xyz> writes:

> Nix solved this particular issue (cpufreq) with a hack.
> It's okay for me, but do some of you agree with applying this:
>
>   # this is a hack and without this cpufreq module is not working. does the following:
>   #   1. moves the "freqset" binary to "e_freqset",
>   #   2. linkes "e_freqset" to enlightenment/bin so that,
>   #   3. wrappers.setuid detects it and places wrappers in /run/wrappers/bin/e_freqset,
>   #   4. and finally, links /run/wrappers/bin/e_freqset to original destination where enlightenment wants it
>   postInstall = ''
>     export CPUFREQ_DIRPATH=`readlink -f $out/lib/enlightenment/modules/cpufreq/linux-gnu-*`;
>     mv $CPUFREQ_DIRPATH/freqset $CPUFREQ_DIRPATH/e_freqset
>     ln -sv $CPUFREQ_DIRPATH/e_freqset $out/bin/e_freqset
>     ln -sv /run/wrappers/bin/e_freqset $CPUFREQ_DIRPATH/freqset
>   '';

No, we shouldn’t apply this hack.  Setuid binaries are declared
separately in the operating system configuration.  See section 6.2.8
Setuid Programs in the manual.

Packages cannot declare setuid binaries.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

bug#27311: Acknowledgement (Enlightenment: 'cpufreq binary needs suid or has to be owned by root')

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

Turns out this one was fixed by 122f91bd413df1606a03050808ead4a7306101ef

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]