all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Alex Kost <alezost@gmail.com>
Cc: 27225-done@debbugs.gnu.org
Subject: bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.
Date: Wed, 7 Jun 2017 15:59:40 -0400	[thread overview]
Message-ID: <20170607195940.GA8987@jasmine> (raw)
In-Reply-To: <87poeg86jb.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

On Wed, Jun 07, 2017 at 12:56:56PM +0300, Alex Kost wrote:
> Leo Famulari (2017-06-03 19:54 -0400) wrote:
> > * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> > use the full commit hash when fetching.

> > +      (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
> 
> As for me, this line is too long, I would make it:
> 
>        (file-name (string-append "guix-artwork-" (string-take commit 7)
>                                  "-checkout"))

Oops! Fixed before pushing as 94db92f78ec9c849f9c8da05d4d35356909f9fbe.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-06-07 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 23:54 bug#27225: [PATCH] artwork: Use a descriptive name for the source directory Leo Famulari
2017-06-06 23:12 ` Ludovic Courtès
2017-06-07  9:56 ` Alex Kost
2017-06-07 19:59   ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607195940.GA8987@jasmine \
    --to=leo@famulari.name \
    --cc=27225-done@debbugs.gnu.org \
    --cc=alezost@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.