From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: 02/02: gnu: Add s. Date: Mon, 5 Jun 2017 08:42:53 +0000 Message-ID: <20170605084253.wnoucacjqv5hk6t7@abyayala> References: <20170604144555.7655.18380@vcs0.savannah.gnu.org> <20170604144556.5AFA1206F7@vcs0.savannah.gnu.org> <878tl770ht.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7smn4o6ibljhiu6s" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHnbY-0005Ze-QS for guix-devel@gnu.org; Mon, 05 Jun 2017 04:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHnbT-0005qQ-UU for guix-devel@gnu.org; Mon, 05 Jun 2017 04:43:16 -0400 Received: from aibo.runbox.com ([91.220.196.211]:39252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHnbT-0005pJ-N5 for guix-devel@gnu.org; Mon, 05 Jun 2017 04:43:11 -0400 Content-Disposition: inline In-Reply-To: <878tl770ht.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --7smn4o6ibljhiu6s Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Mark H Weaver transcribed 1.2K bytes: > kei@openmailbox.org (Kei Kebreau) writes: >=20 > > kkebreau pushed a commit to branch master > > in repository guix. > > > > commit 0e4591bb696a36bc83f75869dd2711987b17b722 > > Author: ng0 > > Date: Tue May 16 22:28:58 2017 +0000 > > > > gnu: Add s. > > =20 > > * gnu/packages/shells.scm (s): New variable. > > =20 > > Signed-off-by: Kei Kebreau > > --- > > gnu/packages/shells.scm | 61 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > > 1 file changed, 61 insertions(+) > > > > diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm > > index 5eeb186..5e04e86 100644 > > --- a/gnu/packages/shells.scm > > +++ b/gnu/packages/shells.scm > > @@ -503,6 +503,67 @@ Its features include: > > @end enumerate\n") > > (license bsd-2))) > > =20 > > +(define-public s > > + (let ((commit "6604341edb3a775ff94415762af3ee9bd86bfb3c") > > + (revision "1")) > > + (package > > + (name "s") > > + (version (string-append "0.0.0-" revision "." (string-take commi= t 7))) >=20 > I think we should rename this package and variable name to 's-shell' or > something along those lines. 's' is commonly used as a local variable > name. Single character variable names are in short supply, and I don't > think we should allocate them to packages. >=20 > Thoughts? >=20 > Mark I did not think of this use, renaming to s-shell is okay. --=20 ng0 OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 --7smn4o6ibljhiu6s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlk1GY0ACgkQ4i+bv+40 hYixVBAArJKmWyly4sM8NaB33Rx+isLi+6SXzyOZCgtD7IvN6z7519/lm5onw8uw jYAIwlotVpb/BOKJ2XCo0JC2kzw2Reqqr/A9RA7Ncex3cs/TYCU1C4UgIu9JfY0z g7AZc4gHym+3CEBMwRC4vYT4YeACKPoU3gupObM8xJ9IUdZVgeNI9HuK9ZhpJdkh ycPwumEFNRcX+x37iEZrOfMQwAWI6wpwUkJJm9aj+ItufVxiq6poDPE053gfoOGc GYDoHEK9ags5PpC2MVI6z8BS/U3QjnHLERHV4SByjTmWmoS8Rl07XRqgzkEju2Xh Wqx0OHQW38UtPN2OtlzefGV5xoUS8Mu27sEWRR2Y/H7kTgzSjavDK5Hjm52qf760 UWtD6QUqzkESpAKDedkrbujKZ10oJclvtu1RAAjL9FS1NHkXL4owCjstUetNzlL6 zfV1dlTM7fWWtvNQ6MGaRMTD515yIwPOwyEo3z1IOrE6RVN+FpB/ZxO/0ss8cE5i +4wED/zYf3sTi62K1U+lLMNDLpklhET5usfbF3LNAYV3eWTVbLTjzwVaxoqrwkkK vUBfAYBZbd7cuTZ0HcnotB/cWUtZhZe80gyrKsDcnoHGs3qvPjA2/PdPiyyU72p9 D+tS7gRX1xF5QuU1WhfZC5FpCgRVJYleU/iuaNMCZSRX/t+zqLc= =+i9N -----END PGP SIGNATURE----- --7smn4o6ibljhiu6s--