From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHYeL-0003H5-IP for guix-patches@gnu.org; Sun, 04 Jun 2017 12:45:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHYeI-00033w-C0 for guix-patches@gnu.org; Sun, 04 Jun 2017 12:45:09 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHYeH-000335-4P for guix-patches@gnu.org; Sun, 04 Jun 2017 12:45:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHYeE-00085v-1O for guix-patches@gnu.org; Sun, 04 Jun 2017 12:45:02 -0400 Subject: bug#27220: [PATCH 3/3] gnu: openldap: Provide path to cyrus-sasl for libtool. Resent-Message-ID: Date: Sun, 4 Jun 2017 12:44:50 -0400 From: Leo Famulari Message-ID: <20170604164450.GF14880@jasmine> References: <87shjfyisq.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="idY8LE8SD6/8DnRI" Content-Disposition: inline In-Reply-To: <87shjfyisq.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 27220@debbugs.gnu.org --idY8LE8SD6/8DnRI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 04, 2017 at 03:38:29PM +0200, Marius Bakke wrote: > Leo Famulari writes: > > * gnu/packages/openldap.scm (openldap)[arguments]: Add 'patch-sasl-path= ' phase.. > > + (add-after 'install 'patch-sasl-path > > + ;; Give -L arguments for cyrus-sasl to avoid propagation. > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (let ((out (assoc-ref outputs "out")) > > + (sasl (assoc-ref inputs "cyrus-sasl"))) > > + (substitute* (map (lambda (f) (string-append out "/" f)) > > + '("lib/libldap.la" "lib/libldap_r.la")) > > + (("-lsasl2" lib) > > + (string-append "-L" sasl "/lib " lib))) > > + #t)))))) >=20 > Good find. LGTM, but I wonder if it would be better to remove the static > library (and associated .la files) and instead provide an explicit > static-package. This mostly for grafting purposes. True. I found this while trying to build the latest ncmpcpp, which added a dependency on curl, which depends on openldap. I copied the solution from t= he hwloc package in (gnu packages mpi). > However, I think that's a journey for another core-updates. Yes :) --idY8LE8SD6/8DnRI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlk0OQIACgkQJkb6MLrK fwgjJw//QT3bUaQJj22Ees3zIOe4Cp4eB8WmwpQS4b9z74jlhvLcBAgdG5w+N2ou fgdmikevzzZbQeb1GY7/GK/54b5Zu1kJg8nm1VrEhJVopWvxVEcNl8LVzIyRkyfl Z13P9atOV8ENWMXBj1upf7cOmKQs5xs3SEQA4xtl+rVy888aD5+RrKZvzFqDpScl ysmnVCRr/3b04r0/MqRGkNA53yDcZthNSYXGqKajRn7i7ax+pTdvu47Un/5lbLRf ARkzfISHpw4IuobeylXBqvnn7PE1qcoZTmKWfc4Gi3HrkkN9gSqaNzlmt0TFHRst q8GvustmEy5ZSO3rPodZx5g0Vf1hdbPhMbX+s5j5JUzP5TwWPVn8xGCvCpZqUS01 i1OOSwJixajbLsTDJokVDwIE0hz/Sjk80fovYqghQ4DVeQA5emPBR3A/zrSZ+i4j /eSiNLD1DCcCZNf7E/7h7oKao7DiYr7UgpeLYd0IQhjljdL4yzj1AkvqjLttDMme 4Il05paTsoh51Tnjq74l2hm7NYvmYTAF5PuUFhoubcYveelF+2oILCDVgj/T713f CmeDYMx0y8cSKaL2x0n5L2nuFsRWNdEpmEbCATDtPJlFu6pZ/u63zHQhr0QPATPX +FHP5JR3DDs1uGLpKEX1Br30MYGMypYB5vbmayc4+J1itgkzNqM= =VOxQ -----END PGP SIGNATURE----- --idY8LE8SD6/8DnRI--