all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27220@debbugs.gnu.org
Subject: bug#27220: [PATCH 2/3] gnu: openldap: Use modify-phases.
Date: Sun, 4 Jun 2017 12:39:47 -0400	[thread overview]
Message-ID: <20170604163947.GE14880@jasmine> (raw)
In-Reply-To: <87vaobyj0g.fsf@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On Sun, Jun 04, 2017 at 03:33:51PM +0200, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > * gnu/packages/openldap.scm (openldap)[arguments]: Use modify-phases syntax.
> > ---
> >  gnu/packages/openldap.scm | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/gnu/packages/openldap.scm b/gnu/packages/openldap.scm
> > index a146ef378..3fd19632b 100644
> > --- a/gnu/packages/openldap.scm
> > +++ b/gnu/packages/openldap.scm
> > @@ -70,10 +70,9 @@
> >     (arguments
> >      `(#:tests? #f
> >        #:phases
> > -       (alist-cons-after
> > -        'configure 'provide-libtool
> > -        (lambda _ (copy-file (which "libtool") "libtool"))
> > -       %standard-phases)))
> > +      (modify-phases %standard-phases
> > +        (add-after 'configure 'provide-libtool
> > +          (lambda _ (copy-file (which "libtool") "libtool"))))))
> 
> Add a #t at the end of this phase while at it.

Okay, will do.

Looking at this phase more closely, I wonder if it's doing the right thing.
Copying libtool into the build tree? That's unusual...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-04 16:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 21:28 bug#27220: OpenLDAP changes for core-updates Leo Famulari
2017-06-03 21:30 ` bug#27220: [PATCH 1/3] gnu: openldap: Update to 2.4.45 Leo Famulari
2017-06-03 21:30   ` bug#27220: [PATCH 2/3] gnu: openldap: Use modify-phases Leo Famulari
2017-06-04 13:33     ` Marius Bakke
2017-06-04 16:39       ` Leo Famulari [this message]
2017-06-03 21:30   ` bug#27220: [PATCH 3/3] gnu: openldap: Provide path to cyrus-sasl for libtool Leo Famulari
2017-06-04 13:38     ` Marius Bakke
2017-06-04 16:44       ` Leo Famulari
2017-06-04 13:33   ` bug#27220: [PATCH 1/3] gnu: openldap: Update to 2.4.45 Marius Bakke
2017-06-04 16:37     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170604163947.GE14880@jasmine \
    --to=leo@famulari.name \
    --cc=27220@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.