bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.

bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.

[Jelle Licht]

* gnu/packages/python.scm (python-apsw)[phases]: Replace build phase; add flag
  to build all extensions.
---
 gnu/packages/python.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 7617490bd..4ce56d45c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5725,6 +5725,10 @@ implementation of D-Bus.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (replace 'build
+           (lambda _
+             (zero?
+              (system* "python" "setup.py" "build" "--enable-all-extensions"))))
          (delete 'check)
          (add-after 'install 'check
            (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.13.0

bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.

[Danny Milosavljevic]

It works.  LGTM.

I get the following message though:

  Not doing LoadExtension test.  You need to compile the extension first
    gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3 src/testextension.c

[bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.

[Ludovic Courtès]

Hello,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> It works.  LGTM.
>
> I get the following message though:
>
>   Not doing LoadExtension test.  You need to compile the extension first
>     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3 src/testextension.c

Jelle, could you check and possibly commit this patch?

Thanks!

Ludo’.

[bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.

[Jelle Licht]

[-- Attachment #1.1: Type: text/plain, Size: 641 bytes --]

I add this command in a phase after build, and adjusted the attached patch
accordingly.
If there are no further issues, I will commit this at the end of this week.


2017-07-20 11:29 GMT+02:00 Ludovic Courtès <ludo@gnu.org>:

> Hello,
>
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
> > It works.  LGTM.
> >
> > I get the following message though:
> >
> >   Not doing LoadExtension test.  You need to compile the extension first
> >     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3
> src/testextension.c
>
> Jelle, could you check and possibly commit this patch?
>
> Thanks!
>
> Ludo’.
>

[-- Attachment #1.2: Type: text/html, Size: 1092 bytes --]

[-- Attachment #2: 0001-gnu-python-apsw-Build-with-all-extensions.patch --]
[-- Type: text/x-patch, Size: 1282 bytes --]

From 3e2176ce3053c6aa6ec84352f417292ccf89e16e Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Sat, 22 Jul 2017 14:23:18 +0200
Subject: [PATCH] gnu: python-apsw: Build with all extensions.

* gnu/packages/python.scm (python-apsw)[phases]: Replace build phase; add flag
  to build all extensions. Add build-test-helper to allow testing of
  extensions.
---
 gnu/packages/python.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 7974dfa58..75046e845 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6025,6 +6025,16 @@ implementation of D-Bus.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (replace 'build
+           (lambda _
+             (zero?
+              (system* "python" "setup.py" "build" "--enable-all-extensions"))))
+         (add-after 'build 'build-test-helper
+           (lambda _
+             (zero?
+              (system
+               (string-append "gcc -fPIC -shared -o ./testextension.sqlext"
+                              "-I. -Isqlite3 src/testextension.c") ))))
          (delete 'check)
          (add-after 'install 'check
            (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.13.3

[bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.

[Ludovic Courtès]

Hello Jelle,

ludo@gnu.org (Ludovic Courtès) skribis:

> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> It works.  LGTM.
>>
>> I get the following message though:
>>
>>   Not doing LoadExtension test.  You need to compile the extension first
>>     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3 src/testextension.c
>
> Jelle, could you check and possibly commit this patch?

Ping!  :-)

Please close it if it’s no longer relevant.

Ludo’.

bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

2017-09-08 17:51 GMT+02:00 Ludovic Courtès <ludo@gnu.org>:

> Hello Jelle,
>
> ludo@gnu.org (Ludovic Courtès) skribis:
>
> > Danny Milosavljevic <dannym@scratchpost.org> skribis:
> >
> >> It works.  LGTM.
> >>
> >> I get the following message though:
> >>
> >>   Not doing LoadExtension test.  You need to compile the extension first
> >>     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3
> src/testextension.c
> >
> > Jelle, could you check and possibly commit this patch?
>
> Ping!  :-)
>
> Please close it if it’s no longer relevant.
>
> Ludo’.
>
Done!

[-- Attachment #2: Type: text/html, Size: 1112 bytes --]

[bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi Jelle!

As proposed earlier, I’ve added you as a committer on Savannah.
Hopefully that will allow you to push all the patches that people have
already okayed but not pushed thinking that you’d do it.  :-)

Please make sure the OpenPGP key at
<https://savannah.gnu.org/users/jlicht> is what you’ll use to sign
commits.  Could you reply to this message signed with this key?

Also please read ‘HACKING’.

That’s it!  Happy hacking, and welcome again!  :-)

Ludo’.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 122 bytes --]


Hi Ludo,

Still being a bit unused at integrating gpg into my workflow, but I
should have it all working now.

- Jelle



[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.

[Ludovic Courtès]

Hi Jelle,

Jelle Licht <jlicht@fsfe.org> skribis:

> Still being a bit unused at integrating gpg into my workflow, but I
> should have it all working now.

This looks good, except that you signed an empty MIME part, not the body
of your message.  :-)

Ludo’.