From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#27212: [PATCH] file-systems: Improve error handling in the
	iso9660 case - fixes boot problem.
Date: Sat, 3 Jun 2017 20:25:00 +0200
Message-ID: <20170603202500.547f3d47@scratchpost.org>
References: <8737bh0zvt.fsf@fastmail.com>
	<20170603180013.15853-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dHDkU-0008VR-0T
	for bug-guix@gnu.org; Sat, 03 Jun 2017 14:26:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dHDkQ-0008H8-Mq
	for bug-guix@gnu.org; Sat, 03 Jun 2017 14:26:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51430)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dHDkQ-0008Gg-FM
	for bug-guix@gnu.org; Sat, 03 Jun 2017 14:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dHDkQ-0002zB-3d
	for bug-guix@gnu.org; Sat, 03 Jun 2017 14:26:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27212.B27212.149651430511417@debbugs.gnu.org>
In-Reply-To: <20170603180013.15853-1-dannym@scratchpost.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 27212@debbugs.gnu.org, ng0 <ng0@pragmatique.xyz>, Marius Bakke <mbakke@fastmail.com>

Hi,

sorry for the slip-up.

The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improved for the case when there's no iso9660 primary volume descriptor anywhere and no terminator either.  In that case the CD is broken.

But if there's no iso9660 volume descriptor AT ALL (primary or not) it's not a fatal error for guix gnu/build/file-systems.scm - it just means we picked the wrong filesystem type and should try the next one.  This case was not handled correctly and this patch addresses this.

I'd like help with testing this patch.  If someone with a fast computer could apply this patch, then run make check-system, and then, if everything worked, run guix system reconfigure /etc/config.scm , that would be great (my computer is building guix master for the last 3 days and probably needs 4 more - so no idea whether the patch works).

@Marius: I don't understand why reverting 203a9455c4695152fc5d0085bffeead9ce3216c2 didn't fix it.  It should have.  (I can't try it myself because I'm in forced-system-update purgatory - argh).