From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Date: Sat, 3 Jun 2017 15:45:55 -0400 Message-ID: <20170603194555.GA23491@jasmine> References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> <20170603202500.547f3d47@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHF0s-0006lf-V4 for bug-guix@gnu.org; Sat, 03 Jun 2017 15:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHF0p-00033e-Ji for bug-guix@gnu.org; Sat, 03 Jun 2017 15:47:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHF0o-000330-7b for bug-guix@gnu.org; Sat, 03 Jun 2017 15:47:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHF0o-0004qM-0U for bug-guix@gnu.org; Sat, 03 Jun 2017 15:47:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20170603202500.547f3d47@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 27212@debbugs.gnu.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 03, 2017 at 08:25:00PM +0200, Danny Milosavljevic wrote: > Hi, >=20 > sorry for the slip-up. >=20 > The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improv= ed > for the case when there's no iso9660 primary volume descriptor anywhere a= nd no > terminator either. In that case the CD is broken. >=20 > But if there's no iso9660 volume descriptor AT ALL (primary or not) it's = not a > fatal error for guix gnu/build/file-systems.scm - it just means we picked= the > wrong filesystem type and should try the next one. This case was not han= dled > correctly and this patch addresses this. >=20 > I'd like help with testing this patch. If someone with a fast computer c= ould > apply this patch, then run make check-system, and then, if everything wor= ked, > run guix system reconfigure /etc/config.scm , that would be great (my com= puter > is building guix master for the last 3 days and probably needs 4 more - s= o no > idea whether the patch works). I don't have access to a fast GuixSD system today. How about reverting the original change now, so that we can reduce the numb= er of people who hit the bug. Then we can test the revised commit afterwards. --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlkzEfMACgkQJkb6MLrK fwhvNQ//UF78ea6o8qrWU8fP8CQSzlRLws0/PPnDzdb1ZO2PXyy+4BuZFZjSflih 754HGQ81nYXyCg4RwAPONUsQ0Z9mJgtKC44nnCRaTtGJWObedas3bZbf0iSTCWxk d7nDQIUi6xy+yIN//sWcNEqAXPe+gEFBP6n2SPOmI7lLmeS1pAz3GISewxqcYvrg rJonm9CrfND6iYEmzRqU432nNUNDUXrk3hxPt2fg7B8IcOmDEuuUUNey5s2X0L1r LHLYp/ysVaGZpPpzZ3mFyNw+du5RmUYEXHEQzg1+Dt1Hqg045KDRjOR2B9u8fdP0 tVwL3i09s9t4VuzTjORejM61ALLI9TYxuxkf8zsCVP/C/iYu6QFy4JZcfpUxB3W8 mN5LYF6uqMidoq/pofMcjEoJKu9nP63r9osQK6kLJkRJFThmQH9g+5ARNCACSoZn J7oG18tH4tOCJcUDe+Mvzg3J6fA89Mz0Ru3+vbUY63lL4wfIzNXbc5bq5ZSCk5as XskJFfdtGRTtsM0t8dsPTksiq8qDxj68E83HbV2C2xgUsV5rimDWvNOX9o2diyE+ kF9t9IH7qEccD3FhzHd0v4/SWrdIEr4eRjNpvZcVI6aDsAi99A/5SGbZTm0fznWG v2nX9POByPWlrxnL5IQ3DXAvvBRcwI5NZwoOjOLZbJA4GYR328c= =gYNL -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--