all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#27174: [PATCH] gpu: packages: python-file: drop outdated patch
@ 2017-05-31 20:08 Sergei Trofimovich
  2017-06-01  7:16 ` Danny Milosavljevic
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2017-05-31 20:08 UTC (permalink / raw)
  To: 27174

The change fixes build failure aftr file-5.30 bump:
python-file-double-encoding-bug.patch was included upstram.

* gnu/local.mk: removed python-file-double-encoding-bug.patch
* gnu/packages/patches/python-file-double-encoding-bug.patch: removed
* gnu/packages/python.scm (python-file): drop upstreamed
  python-file-double-encoding-bug.patch
---
 gnu/local.mk                                       |  1 -
 .../patches/python-file-double-encoding-bug.patch  | 50 ----------------------
 gnu/packages/python.scm                            |  4 --
 3 files changed, 55 deletions(-)
 delete mode 100644 gnu/packages/patches/python-file-double-encoding-bug.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 3d7ae598e..5090c04b9 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -927,7 +927,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/python-3.5-fix-tests.patch		\
   %D%/packages/patches/python-3.5-getentropy-on-old-kernels.patch	\
   %D%/packages/patches/python-dendropy-fix-tests.patch		\
-  %D%/packages/patches/python-file-double-encoding-bug.patch	\
   %D%/packages/patches/python-fix-tests.patch			\
   %D%/packages/patches/python-parse-too-many-fields.patch	\
   %D%/packages/patches/python2-rdflib-drop-sparqlwrapper.patch	\
diff --git a/gnu/packages/patches/python-file-double-encoding-bug.patch b/gnu/packages/patches/python-file-double-encoding-bug.patch
deleted file mode 100644
index bbe825c36..000000000
--- a/gnu/packages/patches/python-file-double-encoding-bug.patch
+++ /dev/null
@@ -1,50 +0,0 @@
-Fix bug that breaks file's Python bindings when using Python 3. This patch
-should not be applied when using Python 2.
-
-Copied from upstream source repository:
-
-https://github.com/file/file/commit/73e043d2a986234b187a00ed0c8d1f7bf83df372
-
-From 73e043d2a986234b187a00ed0c8d1f7bf83df372 Mon Sep 17 00:00:00 2001
-From: Christos Zoulas <christos@zoulas.com>
-Date: Tue, 28 Jun 2016 17:10:22 +0000
-Subject: [PATCH] PR/562: Reiner Herrmann: Avoid double encoding with python3
-
----
- python/magic.py | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/python/magic.py b/python/magic.py
-index c48f7d5..b0f7a17 100644
---- a/python/magic.py
-+++ b/python/magic.py
-@@ -134,7 +134,7 @@ class Magic(object):
-         if isinstance(r, str):
-             return r
-         else:
--            return str(r).encode('utf-8')
-+            return str(r, 'utf-8')
- 
-     def descriptor(self, fd):
-         """
-@@ -152,7 +152,7 @@ class Magic(object):
-         if isinstance(r, str):
-             return r
-         else:
--            return str(r).encode('utf-8')
-+            return str(r, 'utf-8')
- 
-     def error(self):
-         """
-@@ -163,7 +163,7 @@ class Magic(object):
-         if isinstance(e, str):
-             return e
-         else:
--            return str(e).encode('utf-8')
-+            return str(e, 'utf-8')
- 
-     def setflags(self, flags):
-         """
--- 
-2.10.1
-
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b958199bd..aaa69075e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -7578,10 +7578,6 @@ Python's @code{ctypes} foreign function interface (FFI).")
   (package
     (inherit file)
     (name "python-file")
-    (source (origin
-              (inherit (package-source file))
-              ;; This patch should not be applied to python2-file.
-              (patches (search-patches "python-file-double-encoding-bug.patch"))))
     (build-system python-build-system)
     (arguments
      '(#:tests? #f                                ;no tests
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#27174: [PATCH] gpu: packages: python-file: drop outdated patch
  2017-05-31 20:08 bug#27174: [PATCH] gpu: packages: python-file: drop outdated patch Sergei Trofimovich
@ 2017-06-01  7:16 ` Danny Milosavljevic
  0 siblings, 0 replies; 2+ messages in thread
From: Danny Milosavljevic @ 2017-06-01  7:16 UTC (permalink / raw)
  To: Sergei Trofimovich; +Cc: 27174

For core-updates, right?

LGTM! Pushed as 9491227dcbe52fff1b65ebb9b162d825152b7173 to core-updates.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-01  7:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 20:08 bug#27174: [PATCH] gpu: packages: python-file: drop outdated patch Sergei Trofimovich
2017-06-01  7:16 ` Danny Milosavljevic

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.