From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: Switching to Artifex Ghostscript Date: Tue, 30 May 2017 00:40:24 -0400 Message-ID: <20170530044023.GA9717@jasmine> References: <20170520205523.GA27152@jasmine> <87k25b5h5d.fsf@fastmail.com> <87vaougxzy.fsf@elephly.net> <87inkr8fui.fsf@gnu.org> <20170529175013.GA13897@jasmine> <874lw3ik3h.fsf@elephly.net> <87poerz1sl.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFYxM-0007A3-Mj for guix-devel@gnu.org; Tue, 30 May 2017 00:40:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFYxJ-0006M6-Jp for guix-devel@gnu.org; Tue, 30 May 2017 00:40:32 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35403) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFYxJ-0006Lx-79 for guix-devel@gnu.org; Tue, 30 May 2017 00:40:29 -0400 Content-Disposition: inline In-Reply-To: <87poerz1sl.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 29, 2017 at 07:22:18PM -0400, Mark H Weaver wrote: > > Leo Famulari writes: > > > >> + (replace 'build > >> + (lambda _ > >> + ;; Build 'libgs.so', but don't build the statically-link= ed 'gs' > >> + ;; binary (saves 22 MiB). > >> + (zero? (system* "make" "so" "-j" > >> + (number->string > >> (parallel-job-count)))))) > > > > Couldn=E2=80=99t we just add =E2=80=9C#:make-flags '("so")=E2=80=9D and= avoid replacing the > > build phase? >=20 > FWIW, I think it's a bad habit to abuse #:make-flags for targets, > because the contents of #:make-flags is also passed to 'make' during the > 'install' and 'check' phases. That's a good point. For this package I think we can just re-use the build phase replacement from the GNU Ghostscript package, as in v1 of my patch. > IMO, if we want to avoid replacing the build phase in cases like this, > it would be better to add a separate #:build-target argument. >=20 > Thoughts? Yes, it could be useful. --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlks97AACgkQJkb6MLrK fwjuRg//XwZljEwwEQbr/hawnzBOqFlS/hMf1WrCSU/WhDv7Bu+cPl+idUAxdP4/ 7AsJv//0qcytzpgiP3Y3Dn57dDLb5jqWzGzMSYndwT/ykXwqXZSV1Qi1JUyTGVsi 8xDTKa39ijsFivJsKoHYVDO7wUjjZDg22MDSFxZEZvTCdItOxhpPBDq6nNpP7eRZ Wkgn/jY017vT9eiNxl2/RynVBw6aiZEfoEctH3xaiTxY3/w6JkGdaSIF1Wi6sikC wSUmG5saEASzQTB385KpUIAEHAem/sb0HUzJGjElmIu+HiMoyIVpiT1YiaNC14zy BcLOoN/2hLSf4meO910nn6AR+xZ9YoZOFNAfStrLp30321brVnZCLl3CHccgoeuY g5ynVS11/OELYWQ14JWqleL6ZNNI9eHnn5bsAe5nWxYO2dSga4J2a2EBt5LOPnxs 9eaGwh6S0xhR+V1zXj2ggx8joSq3+GA8e8uUzwki3DxQmppRvQz0RVVnpnvPfkUR khj4chYTsV1EjFyn5y1nAhd59/EpaYhn4eNhK0s4YaT7XUhEaxi1rk+TkOhZnziN YLJZ0PSDV/8AVZ1I+yagCAnrMKadpZ3Zw4jlp7DB999AKSi750wuEZwJpvZvOgMC QXOLIWx2hCJI2nphDIFINkpO1e2AaQv/7YYoHpo298wVD7u+0UA= =w9wJ -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--