Re: 01/01: gnu: packages: flex: Add missing 'lzip' input.

Re: 01/01: gnu: packages: flex: Add missing 'lzip' input.

[Ludovic Courtès]

leo@famulari.name (Leo Famulari) skribis:

> lfam pushed a commit to branch core-updates
> in repository guix.
>
> commit 77e2538eda8a2721aef8336103c94fe31e12870c
> Author: Sergei Trofimovich <slyfox@inbox.ru>
> Date:   Sat May 27 12:27:47 2017 +0100
>
>     gnu: packages: flex: Add missing 'lzip' input.
>     
>     * gnu/packages/flex.scm (flex)[native-inputs]: Add lzip.
>     
>     Signed-off-by: Leo Famulari <leo@famulari.name>

I think this breaks ‘flex-boot0’ in (gnu packages commencement), doesn’t
it?

It should easily fixed, but I think it might be better to avoid adding
lzip to the early dependency graph.  IOW, if Flex is also available as
tar.gz or tar.bz2 or tar.xz, we should do that.

(Eventually we might want adding lzip and/or removing bzip2 from the set
of bootstrap tools, but that’s another story.)

Thoughts?

Ludo’.

Re: 01/01: gnu: packages: flex: Add missing 'lzip' input.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Sun, May 28, 2017 at 02:51:10PM +0200, Ludovic Courtès wrote:
> leo@famulari.name (Leo Famulari) skribis:
> >     gnu: packages: flex: Add missing 'lzip' input.
> >     
> >     * gnu/packages/flex.scm (flex)[native-inputs]: Add lzip.
> 
> I think this breaks ‘flex-boot0’ in (gnu packages commencement), doesn’t
> it?
> 
> It should easily fixed, but I think it might be better to avoid adding
> lzip to the early dependency graph.  IOW, if Flex is also available as
> tar.gz or tar.bz2 or tar.xz, we should do that.

Ah, right. Fixed with 2dca204eb02835504df6846d9a543c729dc612e4.

> (Eventually we might want adding lzip and/or removing bzip2 from the set
> of bootstrap tools, but that’s another story.)

If we have to, but for now we don't :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 01/01: gnu: packages: flex: Add missing 'lzip' input.

[Sergei Trofimovich]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

On Sun, 28 May 2017 09:58:07 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Sun, May 28, 2017 at 02:51:10PM +0200, Ludovic Courtès wrote:
> > leo@famulari.name (Leo Famulari) skribis:  
> > >     gnu: packages: flex: Add missing 'lzip' input.
> > >     
> > >     * gnu/packages/flex.scm (flex)[native-inputs]: Add lzip.  
> > 
> > I think this breaks ‘flex-boot0’ in (gnu packages commencement), doesn’t
> > it?

Can you clarify a bit what exactly broke here? Is it bootstrap on hurd?
guix seemed to build things fine here on linux.

I don't understand how flex could work before the patch as lzip was not
pulled in as a dependency and the tarball is clearly an .lz one.

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: 01/01: gnu: packages: flex: Add missing 'lzip' input.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

On Sun, May 28, 2017 at 06:37:02PM +0100, Sergei Trofimovich wrote:
> > On Sun, May 28, 2017 at 02:51:10PM +0200, Ludovic Courtès wrote:
> > > leo@famulari.name (Leo Famulari) skribis:  
> > > >     gnu: packages: flex: Add missing 'lzip' input.
> > > >     
> > > >     * gnu/packages/flex.scm (flex)[native-inputs]: Add lzip.  
> > > 
> > > I think this breaks ‘flex-boot0’ in (gnu packages commencement), doesn’t
> > > it?
> 
> Can you clarify a bit what exactly broke here? Is it bootstrap on hurd?
> guix seemed to build things fine here on linux.

See the flex-boot0 package in 'gnu/packages/commencement.scm. This
package inherits from flex but limits the native-inputs to bison-boot0
and %boot0-inputs. So, lzip is not available here.

Although I didn't try building it from the lzip-compressed tarball, I
expect flex-boot0 would fail to build unless we added lzip to its
native-inputs. Did work for you?

> I don't understand how flex could work before the patch as lzip was not
> pulled in as a dependency and the tarball is clearly an .lz one.

Right, since commit 93fabf59962aeb15981bd547850de1dab69eccfb (gnu: flex:
Update to 2.6.4.) the flex package was broken. We didn't notice right
away because it was on core-updates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]