On Fri, May 26, 2017 at 06:57:45PM +0200, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, May 26, 2017 at 03:19:06PM +0200, Marius Bakke wrote:
> >> Leo Famulari <leo@famulari.name> writes:
> >> 
> >> > * gnu/packages/python.scm (python-cryptography, python2-cryptography,
> >> > python-cryptography-vectors, python2-cryptography-vectors):
> >> > Update to 1.8.1.
> >> > (python-cryptography, python2-cryptography)[propagated-inputs]: Add
> >> > python-asn1crypto and python-packaging.
> >> 
> >> I'm very confused about the 'packaging' dependency. Grepping for
> >> 'packaging' in the code returns zero hits. Do you know how it's used?
> >
> > Here are the results:
> >
> > $ pwd
> > /home/leo/tmp/cryptography-1.8.1
> > $ grep -rI packaging
> > src/cryptography/utils.py:from packaging.version import parse
> > src/cryptography.egg-info/requires.txt:packaging
> >
> > Did you search in another version of the code?
> 
> Odd. Since the patch did not apply, I went ahead and cloned the
> repository:
> 
> 0 ✓ ~/git/python-cryptography $ git grep -i packaging
> 1 ✗ ~/git/python-cryptography $ 
> 
> Digging through the log, it seems this dependency is removed in 1.9. Can
> you mention that in a comment? :-)
> 
> https://github.com/pyca/cryptography/pull/3524/commits/d25152ba9e8a466d9521543002a2ee2f2b4cafc3
> 
> > Having read that code, perhaps we should try updating cffi soon. It
> > checks if cffi is version 1.7. We package 1.4.2; 1.10.0 is the latest.
> 
> Sounds good!

Thanks for reviewing! Pushed as dc1bd2b560a490be17fed67131544ebe1e60673f