all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27081-done@debbugs.gnu.org
Subject: bug#27081: [PATCH 2/2] gnu: python-cryptography: Update to 1.8.1.
Date: Fri, 26 May 2017 14:52:31 -0400	[thread overview]
Message-ID: <20170526185230.GA24342@jasmine> (raw)
In-Reply-To: <877f13tv1y.fsf@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Fri, May 26, 2017 at 06:57:45PM +0200, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, May 26, 2017 at 03:19:06PM +0200, Marius Bakke wrote:
> >> Leo Famulari <leo@famulari.name> writes:
> >> 
> >> > * gnu/packages/python.scm (python-cryptography, python2-cryptography,
> >> > python-cryptography-vectors, python2-cryptography-vectors):
> >> > Update to 1.8.1.
> >> > (python-cryptography, python2-cryptography)[propagated-inputs]: Add
> >> > python-asn1crypto and python-packaging.
> >> 
> >> I'm very confused about the 'packaging' dependency. Grepping for
> >> 'packaging' in the code returns zero hits. Do you know how it's used?
> >
> > Here are the results:
> >
> > $ pwd
> > /home/leo/tmp/cryptography-1.8.1
> > $ grep -rI packaging
> > src/cryptography/utils.py:from packaging.version import parse
> > src/cryptography.egg-info/requires.txt:packaging
> >
> > Did you search in another version of the code?
> 
> Odd. Since the patch did not apply, I went ahead and cloned the
> repository:
> 
> 0 ✓ ~/git/python-cryptography $ git grep -i packaging
> 1 ✗ ~/git/python-cryptography $ 
> 
> Digging through the log, it seems this dependency is removed in 1.9. Can
> you mention that in a comment? :-)
> 
> https://github.com/pyca/cryptography/pull/3524/commits/d25152ba9e8a466d9521543002a2ee2f2b4cafc3
> 
> > Having read that code, perhaps we should try updating cffi soon. It
> > checks if cffi is version 1.7. We package 1.4.2; 1.10.0 is the latest.
> 
> Sounds good!

Thanks for reviewing! Pushed as dc1bd2b560a490be17fed67131544ebe1e60673f

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-26 18:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26  7:38 bug#27081: Update python-cryptography to 1.8.1 Leo Famulari
2017-05-26  7:41 ` bug#27081: [PATCH 1/2] gnu: Add python-packaging Leo Famulari
2017-05-26  7:41   ` bug#27081: [PATCH 2/2] gnu: python-cryptography: Update to 1.8.1 Leo Famulari
2017-05-26 13:19     ` Marius Bakke
2017-05-26 16:41       ` Leo Famulari
2017-05-26 16:57         ` Marius Bakke
2017-05-26 18:52           ` Leo Famulari [this message]
2017-05-26 13:11   ` bug#27081: [PATCH 1/2] gnu: Add python-packaging Marius Bakke
2017-05-26 16:43     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170526185230.GA24342@jasmine \
    --to=leo@famulari.name \
    --cc=27081-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.