From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27081@debbugs.gnu.org
Subject: bug#27081: [PATCH 1/2] gnu: Add python-packaging.
Date: Fri, 26 May 2017 12:43:39 -0400 [thread overview]
Message-ID: <20170526164339.GB23676@jasmine> (raw)
In-Reply-To: <87inknu5jg.fsf@fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Fri, May 26, 2017 at 03:11:15PM +0200, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > +;;; From 'LICENSE': This software is made available under the terms of *either*
> > +;;; of the licenses found in LICENSE.APACHE or LICENSE.BSD. Contributions to
> > +;;; this software is made under the terms of *both* these licenses.
>
> Please only use two semicolons here, with indentation. IMO the "triple
> semicolons" are for "meta-commentary" about the module, not for code
> comments.
Okay, the Guile manual doesn't suggest this, but it seems fine.
> Other than that looks good. As a side note, I typically don't append to
> modules since the patch context quickly becomes outdated (like now), but
> that's another issue entirely :-)
That's my burden to bear in this case :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-05-26 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 7:38 bug#27081: Update python-cryptography to 1.8.1 Leo Famulari
2017-05-26 7:41 ` bug#27081: [PATCH 1/2] gnu: Add python-packaging Leo Famulari
2017-05-26 7:41 ` bug#27081: [PATCH 2/2] gnu: python-cryptography: Update to 1.8.1 Leo Famulari
2017-05-26 13:19 ` Marius Bakke
2017-05-26 16:41 ` Leo Famulari
2017-05-26 16:57 ` Marius Bakke
2017-05-26 18:52 ` Leo Famulari
2017-05-26 13:11 ` bug#27081: [PATCH 1/2] gnu: Add python-packaging Marius Bakke
2017-05-26 16:43 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526164339.GB23676@jasmine \
--to=leo@famulari.name \
--cc=27081@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.