From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEIJR-0000lW-Sw for guix-patches@gnu.org; Fri, 26 May 2017 12:42:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEIJO-00073W-PQ for guix-patches@gnu.org; Fri, 26 May 2017 12:42:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36792) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dEIJO-000736-08 for guix-patches@gnu.org; Fri, 26 May 2017 12:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dEIJN-0000f7-Ne for guix-patches@gnu.org; Fri, 26 May 2017 12:42:01 -0400 Subject: bug#27081: [PATCH 2/2] gnu: python-cryptography: Update to 1.8.1. Resent-Message-ID: Date: Fri, 26 May 2017 12:41:31 -0400 From: Leo Famulari Message-ID: <20170526164131.GA23676@jasmine> References: <797cba6a22e1f1e0363a857cae509ae659a127ce.1495784519.git.leo@famulari.name> <87fufru56d.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <87fufru56d.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 27081@debbugs.gnu.org --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 26, 2017 at 03:19:06PM +0200, Marius Bakke wrote: > Leo Famulari writes: >=20 > > * gnu/packages/python.scm (python-cryptography, python2-cryptography, > > python-cryptography-vectors, python2-cryptography-vectors): > > Update to 1.8.1. > > (python-cryptography, python2-cryptography)[propagated-inputs]: Add > > python-asn1crypto and python-packaging. >=20 > I'm very confused about the 'packaging' dependency. Grepping for > 'packaging' in the code returns zero hits. Do you know how it's used? Here are the results: $ pwd /home/leo/tmp/cryptography-1.8.1 $ grep -rI packaging src/cryptography/utils.py:from packaging.version import parse src/cryptography.egg-info/requires.txt:packaging Did you search in another version of the code? > How does it fail without it? A comment would be good. The program uses the packaging.version module at run-time, and simply crashes when it can't find it. Here is the part where it uses code from that module: $ sed -n 103,105p src/cryptography/utils.py def _version_check(version, required_version): # This is used to check if we support update_into on CipherContext. return parse(version) >=3D parse(required_version) This function gets used to check the version of python-cffi in 'src/cryptography/hazmat/primitives/ciphers/base.py' and branch based on it. Having read that code, perhaps we should try updating cffi soon. It checks if cffi is version 1.7. We package 1.4.2; 1.10.0 is the latest. > Also note, 1.8.2 was released a few hours ago. I assume you've tested > some of the important-looking dependencies, so let's get this in :-) Yes, of course I tested some important packages, like certbot :) I'll retest with this new version. I don't expect big changes. --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlkoWrgACgkQJkb6MLrK fwgq3BAAyAHMjCz5R8w0nf/cZeCgupk8jr/PpB0ix4yboDuS1t+7g8TQ03mV4Peh 8lUXrMBgRco730OTGK+1Tz/q7gjdVDzS7R+w4VdbiMTxXfkNgep9VnqSwaRSBnVJ 5E2V4p+3Mra7GUh7Ne5aQp5nJIgpURedx4aen0JDGc5LUiExCKQ/yGvE6vrl/TRt H3JMNm3aivQtCRZDVSk7GTYNYFh7voEtmBV7YvwL2NBU1KQ+R8M6zr6///GJCZpL G2pXryyNhxsU3SPvu0PXc3KwaqnhJA/KRyVIkBe8K01PCIu0uzWSAi+z7hb4mkbo vODg/oa4NILz91MB6ezXpvvdy5M4is+FXze4txYBxRskKyHRmolzukqrBPxP5sx0 Iz5RpmeQcOzopn8Xr6lUCG/d86rfibyZxt/D9MIJotJtYMe3yV9SmfujhyuCUvoa wt5dQ4SCtLm9YLHPv4mPevzYJgQdz80DaYVF29ZbDA5sfsJ7AUeq9+zA28BBkICN nk9axyKD5SPwcrHqdsvpleL6UrLLB8GaT85llrLzDc/Pe+yoTbeEVHZcxYOHilX0 8uoIIv8flvt6nWpfQTgGC6c8vWfIMCUr9quWAa/iT6YZUd66eDWDfjGZ4u9Xhxk9 9GsSThwOivlWgm58ms+ndE7VW2KSqViwd2EuRyESFJmKStCUJHk= =ZEqo -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--