From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDygz-0003bd-CD for guix-patches@gnu.org; Thu, 25 May 2017 15:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDygw-0004mQ-6r for guix-patches@gnu.org; Thu, 25 May 2017 15:45:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDygv-0004mE-UT for guix-patches@gnu.org; Thu, 25 May 2017 15:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dDygv-0001vn-P7 for guix-patches@gnu.org; Thu, 25 May 2017 15:45:01 -0400 Subject: bug#27043: [PATCH] gnu: Add python-asn1crypto. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 25 May 2017 15:44:29 -0400 From: Leo Famulari Message-ID: <20170525194429.GA977@jasmine> References: <112e5a50205629b8d4c5de726c45f6c2f1666699.1495568547.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 27043-done@debbugs.gnu.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 24, 2017 at 01:24:41PM +0530, Arun Isaac wrote: > Leo Famulari writes: > > * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New = variables. >=20 > I think we should put this package in gnu/packages/python.scm. Packages > like python-cryptography are in python.scm. There are performance issues with Guile 2.2, and the huge (gnu packages python) module is really a pathological case [0]. So, if a new package makes sense in other modules, I'll be adding them in those other modules, at least until the compiler performance is improved. https://lists.gnu.org/archive/html/guile-devel/2017-05/msg00033.html > > + (uri (pypi-uri "asn1crypto" version)) >=20 > Release tarballs are availabe on the project's github page. Why not use > those? >=20 > > + (arguments > > + '(#:tests? #f)) ; Tests are not distributed via PyPi. >=20 > The github release tarballs have tests. Could you package them? Aha! Good catch. >=20 > > + (description "Fast ASN.1 parser and serializer with definitions fo= r private > > +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#= 8, > > +PKCS#12, PKCS#5, X.509 and TSP.") >=20 > The description should be in full sentences. Indeed, fixed! Thanks for the review! Pushed as 10e65d5e5adde4e17bae47f0b59b36df264ded39 --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlknNB0ACgkQJkb6MLrK fwgo7BAAtYXGNs98T4EHirD2jSXADesX2Xc2Aml7b3miTohpJ7T6WLc7wwt/6Qpp vQBy5BKMp1j7yGxo0/jUpPRRGcZ7QzH9Ya5MGckC5FZGttong/RfnYeQfCAS4nox nnEk0Q5yAObNAPRlaoasV1LMA7YD316zc7oUvdYjO6vWq29jR3XoAAdkz2YoOo38 nd6TZmTcNixE6uxfjFqt/0dfFaDSNcEiaGL6yHvT8re10oXGNaCAlENYSwVKYAHE 7nxPqd/GXoMMrCJY0KSWZ8ssYfvPmMmLXEF68DgTyW9cDYZ0eYRZdiS+9wSRYM4/ 90Qgokd9BlLvcw7/M0Lo6gj/sFmacpXktrB4n5WANUKFqz7j065meTArQLydWpe2 KTw9a6xdYoBcWg6bpxFTsr+O5A6AjYKA2GAtNznpl+9mId3oDhG58ZLn+2yz9jIx fVUqkRBBoMZWuxbRCoHh8sHx1w0I3BnvT8y0llTpWQig6H/azqN9N/ub+xnFfidy dJhAt+SbE5YzN2mrGYNp9bUF+aHDqgdXdEHUCrU1FYwuJRF78YYw0dYrrhYH8HLn IqytO2bqX5qWz9aBSP4QQwMOnBTewBCUKUfuZHBHFxfRAcMbxHMa8pIlIgX+CpQf yPs8Sa+/99/GMGM9/InVkcU759Ey05n/K6V5MPFQ4r4XadagKhs= =dDv0 -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--