From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9p8H-0001v9-5l for guix-patches@gnu.org; Sun, 14 May 2017 04:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9p8E-0001WU-3f for guix-patches@gnu.org; Sun, 14 May 2017 04:44:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9p8D-0001WO-W5 for guix-patches@gnu.org; Sun, 14 May 2017 04:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9p8D-0005Af-M7 for guix-patches@gnu.org; Sun, 14 May 2017 04:44:01 -0400 Subject: bug#26339: [PATCH v4 1/7] bootloader: Add extlinux support. Resent-Message-ID: Date: Sun, 14 May 2017 10:43:47 +0200 From: Danny Milosavljevic Message-ID: <20170514104347.1a87906f@scratchpost.org> In-Reply-To: <20170514074803.25556-2-m.othacehe@gmail.com> References: <20170514074803.25556-1-m.othacehe@gmail.com> <20170514074803.25556-2-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26339@debbugs.gnu.org Hi Mathieu, >+++ b/gnu/bootloader.scm [...] >+(define-record-type* > + (menu-entries bootloader-configuration-menu-entries ; list of > + (default '())) At first I thought this could be confused with grub menu-entries - but on second thought they are similar enough. > + (timeout bootloader-configuration-timeout ; integer > + (default 5)) Can you add a comment about the unit? > +(define (lookup-bootloader-by-name name) > + "Return the bootloader called NAME." > + (or (find (lambda (bootloader) > + (format #t "~a\n" (eq? name (bootloader-name bootloader))) Left-over debugging message? > (append (map boot-parameters->menu-entry entries) > - (grub-configuration-menu-entries config))) > + (bootloader-configuration-menu-entries config))) So bootloader-configuration-menu-entries are grub menu-entries, right? Earlier the code said they were boot-parameters (see quoted text above). >+++ b/gnu/bootloader/grub.scm > +(define-syntax-rule (grub-configuration fields ...) > + (bootloader-configuration > + (bootloader grub-bootloader) > + fields ...)) Will these be able to resolve the symbols used? Because there are new modules now etc - do old configuration files which don't import those modules still work? > - (entry (operating-system-boot-parameters os system root-device))) > - ((module-ref (resolve-interface '(gnu system grub)) > - 'grub-configuration-file) > - (operating-system-bootloader os) > - (list entry) > - #:old-entries old-entries))) > + (entry (operating-system-boot-parameters os system root-device)) > + (bootloader-conf -> (operating-system-bootloader os))) > + ((bootloader-configuration-file-generator > + (bootloader-configuration-bootloader bootloader-conf)) > + bootloader-conf (list entry) #:old-entries old-entries))) Yay my band-aid is gone :) Remainder of this patch LGTM!