From: Thomas Danckaert <post@thomasdanckaert.be>
To: ludo@gnu.org, Danny Milosavljevic <dannym@scratchpost.org>,
Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26669@debbugs.gnu.org, 26669-close@debbugs.gnu.org
Subject: bug#26669: [PATCH 1/7] gnu: Add cdrtools.
Date: Wed, 10 May 2017 09:48:34 +0200 (CEST) [thread overview]
Message-ID: <20170510.094834.43521092439100471.post@thomasdanckaert.be> (raw)
In-Reply-To: <8760hit7tr.fsf@gnu.org> <87r306rt00.fsf@gnu.org>
Hi all,
Thanks for your comments.
I pushed the series to master, with all comments addressed. Except
these 2 by Ludo, where I didn't really manage...
From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: bug#26669: [PATCH 1/7] gnu: Add cdrtools.
Date: Wed, 03 May 2017 14:59:12 +0200
>> +++ b/gnu/packages/patches/cdrtools-3.01-mkisofs-isoinfo.patch
>> @@ -0,0 +1,514 @@
>> +Patch for version 3.01, taken from upstream at
>> +https://sourceforge.net/projects/cdrtools/files/cdrtools-3.01-fix-20151126-mkisofs-isoinfo.patch
>
> It would be nice to add a few words about what it does, like “Fix
> compilation with recent glibc” or something.
Unfortunately, I couldn't find a proper explanation for the patch,
and I'm not familiar enough with the cdrtools code base to completely
understand it myself. It seems like it fixes some issues and
upgrades half-way to 3.02 at the same time... Well at least we can
get rid of the patch if/when they release 3.02.
From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: bug#26669: [PATCH 7/7] gnu: Add dvdstyler.
Date: Wed, 03 May 2017 15:04:47 +0200
>> + (arguments
>> + `(#:configure-flags (list (string-append "XMLTO="
>> + (assoc-ref
>> %build-inputs "xmlto")
>> + "/bin/xmlto"
>> + " --searchpath "
>> + (assoc-ref
>> %build-inputs "docbook-xsl")
>> +
>> "/xml/xsl/docbook-xsl-1.79.1/htmlhelp:"
>> + (assoc-ref
>> %build-inputs "docbook-xml")
>> + "/xml/dtd/docbook"))
>
> I'd expect that adding libxml2 as an input would lead to the
> appropriate
> definition of XML_CATALOG_FILES, and thus remove the need for these
> #:configure-flags. Could you try that?
I tried it, but it didn't work. Even with these flags, documentation
generation phase spits out a few warnings about attempted network
access to retrieve xsd files, but way less than without the flags,
and at html help is generated successfully :-) .
Thomas
next prev parent reply other threads:[~2017-05-10 7:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 16:05 bug#26669: [PATCH 1/7] gnu: Add cdrtools Thomas Danckaert
2017-04-26 16:30 ` bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools Thomas Danckaert
2017-04-26 16:30 ` bug#26669: [PATCH 3/7] gnu: brasero: Embed growisofs store item Thomas Danckaert
2017-04-28 5:54 ` Danny Milosavljevic
2017-04-26 16:30 ` bug#26669: [PATCH 4/7] gnu: Add dvdauthor Thomas Danckaert
2017-04-27 18:50 ` Danny Milosavljevic
2017-04-26 16:30 ` bug#26669: [PATCH 5/7] gnu: Add wxwidgets-3.1 Thomas Danckaert
2017-05-03 13:00 ` Ludovic Courtès
2017-04-26 16:30 ` bug#26669: [PATCH 6/7] gnu: Add wxsvg Thomas Danckaert
2017-05-03 13:02 ` Ludovic Courtès
2017-04-26 16:30 ` bug#26669: [PATCH 7/7] gnu: Add dvdstyler Thomas Danckaert
2017-05-03 13:04 ` Ludovic Courtès
2017-05-10 7:48 ` Thomas Danckaert [this message]
2017-05-10 11:55 ` bug#26669: [PATCH 1/7] gnu: Add cdrtools Ludovic Courtès
2017-04-26 17:15 ` bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools Danny Milosavljevic
2017-04-26 16:59 ` bug#26669: [PATCH 1/7] gnu: Add cdrtools Mathieu Othacehe
2017-05-03 12:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510.094834.43521092439100471.post@thomasdanckaert.be \
--to=post@thomasdanckaert.be \
--cc=26669-close@debbugs.gnu.org \
--cc=26669@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=ludo@gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.