all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26818@debbugs.gnu.org
Subject: bug#26818: Certbot with Python 3
Date: Mon, 8 May 2017 14:00:06 -0400	[thread overview]
Message-ID: <20170508180006.GG7235@jasmine> (raw)
In-Reply-To: <87inlbydrq.fsf@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Mon, May 08, 2017 at 10:05:29AM +0200, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > * gnu/packages/python.scm (python-mock-2): New variable.
> 
> [...]
> 
> > +;;; Some packages (notably, certbot and python-acme) rely on this newer version
> > +;;; of python-mock. However, a large number of packages fail to build with
> > +;;; mock@2, so we add a new variable for now. Also, there may be a dependency
> > +;;; cycle between mock and six, so we avoid creating python2-mock@2 for now.
>   ^^^^
> Only two semicolons. The patches LGTM otherwise.

The convention is to use 3 when the comment starts at the beginning of
the line:

https://www.gnu.org/software/guile/manual/html_node/Comments.html

Thank you for reviewing my patches!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-08 18:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07 18:46 bug#26818: Certbot with Python 3 Leo Famulari
2017-05-08  8:05 ` Marius Bakke
2017-05-08 18:00   ` Leo Famulari [this message]
2017-06-18 11:10 ` [bug#26818] " Ricardo Wurmus
2017-06-19 17:08   ` bug#26818: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170508180006.GG7235@jasmine \
    --to=leo@famulari.name \
    --cc=26818@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.