all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 26817@debbugs.gnu.org
Subject: bug#26817: [PATCH] gnu: Add pngcrunch.
Date: Sun, 7 May 2017 19:36:46 -0400	[thread overview]
Message-ID: <20170507233646.GB20778@jasmine> (raw)
In-Reply-To: <1494177899-20012-1-git-send-email-h.goebel@crazy-compilers.com>

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

On Sun, May 07, 2017 at 07:24:59PM +0200, Hartmut Goebel wrote:
> * gnu/packages/image.scm (pngcrunch): New variable.

Thanks, LGTM overall!

> +              (("\\$\\(DESTDIR\\)/usr/")
> +               (string-append (assoc-ref outputs "out") "/"))))))))

That's strange; DESTDIR is typically an intermediate location between
the source directory and PREFIX. I assume this Makefile is written by
hand?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-07 23:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07 17:24 bug#26817: [PATCH] gnu: Add pngcrunch Hartmut Goebel
2017-05-07 23:36 ` Leo Famulari [this message]
2017-05-08  7:27   ` Hartmut Goebel
2017-05-08 17:26     ` Leo Famulari
2017-05-09 18:12       ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170507233646.GB20778@jasmine \
    --to=leo@famulari.name \
    --cc=26817@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.