bug#26792: Fix output of --help in package fish

bug#26792: Fix output of --help in package fish

[ng0]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

Currently the output of fish --help fails if the nroff binary is not found.
The patch fixes the issue by embeding a reference to the groff provided nroff,
fish --help produces correct output after this is applied.
-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

[-- Attachment #2: 0001-gnu-fish-Reference-groff-to-fix-output-of-fish-help.patch --]
[-- Type: text/plain, Size: 1751 bytes --]

From 5a22ffdccef3266f6a4050f715f304c10c259ba3 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@no-reply.pragmatique.xyz>
Date: Sat, 6 May 2017 00:12:58 +0000
Subject: [PATCH] gnu: fish: Reference 'groff' to fix output of 'fish --help'.

* gnu/packages/shells.scm (fish)[native-inputs]: Add 'groff'.
(arguments): Add 'nroff' substitution in 'embed-store-paths' phase.
---
 gnu/packages/shells.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index d87d58e5c..6f06acfa4 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -31,6 +31,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages documentation)
+  #:use-module (gnu packages groff)
   #:use-module (gnu packages libedit)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
@@ -112,7 +113,8 @@ direct descendant of NetBSD's Almquist Shell (@command{ash}).")
                   ((".*INSTALL.*sysconfdir.*fish.*") "")))))
     (build-system gnu-build-system)
     (native-inputs
-     `(("doxygen" ,doxygen)))
+     `(("doxygen" ,doxygen)
+       ("groff" ,groff)))
     (inputs
      `(("bc" ,bc)
        ("ncurses" ,ncurses)
@@ -133,6 +135,8 @@ direct descendant of NetBSD's Almquist Shell (@command{ash}).")
                                "/bin/bc")))
              (substitute* "share/functions/fish_update_completions.fish"
                (("python") (which "python")))
+             (substitute* "share/functions/__fish_print_help.fish"
+               (("nroff") (which "nroff")))
              #t)))))
     (synopsis "The friendly interactive shell")
     (description
-- 
2.12.2

bug#26792: Acknowledgement (Fix output of --help in package fish)

[ng0]

I just created a new user which uses fish as the login shell and
I need to update this patch. There is more to be embeded for fish.
GNU bug Tracking System transcribed 0.7K bytes:
> Thank you for filing a new bug report with debbugs.gnu.org.
> 
> This is an automatically generated reply to let you know your message
> has been received.
> 
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
> 
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
> 
> If you wish to submit further information on this problem, please
> send it to 26792@debbugs.gnu.org.
> 
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
> 
> -- 
> 26792: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26792
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems

-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

bug#26792: Acknowledgement (Fix output of --help in package fish)

[ng0]

ng0 transcribed 1.0K bytes:
> I just created a new user which uses fish as the login shell and
> I need to update this patch. There is more to be embeded for fish.

This is similar to the "mc" situation.

In a plain fish profile with no bash whatsoever, your default $PATH is:

echo $PATH
/usr /usr/bin

the major issue when logging in is:

1. grep is not found.
2. hostname is not found.

The question to think about is, how do we provide access to the basic
applications (grep, awk, hostname, etc) fish needs? Substituting a minimal
set of files where necessary seems like the best working solution for a
system which does not assume any other shell and therefore does initially
export no $PATH other than /usr and /usr/bin.

The very least I want people to experience is no error immediately after
first login. This happens at the moment.
-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

bug#26792: Acknowledgement (Fix output of --help in package fish)

[ng0]

ng0 transcribed 0.9K bytes:
> ng0 transcribed 1.0K bytes:
> > I just created a new user which uses fish as the login shell and
> > I need to update this patch. There is more to be embeded for fish.
> 
> This is similar to the "mc" situation.
> 
> In a plain fish profile with no bash whatsoever, your default $PATH is:
> 
> echo $PATH
> /usr /usr/bin

A correction: $PATH = /bin /usr/bin

> the major issue when logging in is:
> 
> 1. grep is not found.
> 2. hostname is not found.
> 
> The question to think about is, how do we provide access to the basic
> applications (grep, awk, hostname, etc) fish needs? Substituting a minimal
> set of files where necessary seems like the best working solution for a
> system which does not assume any other shell and therefore does initially
> export no $PATH other than /usr and /usr/bin.
> 
> The very least I want people to experience is no error immediately after
> first login. This happens at the moment.
> -- 
> https://pragmatique.xyz
> PGP: https://people.pragmatique.xyz/ng0/
> 
> 
> 

-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

bug#26792: Fix output of --help in package fish

[Ludovic Courtès]

ng0 <ng0@pragmatique.xyz> skribis:

> Currently the output of fish --help fails if the nroff binary is not found.
> The patch fixes the issue by embeding a reference to the groff provided nroff,
> fish --help produces correct output after this is applied.
> -- 
> https://pragmatique.xyz
> PGP: https://people.pragmatique.xyz/ng0/
>
> From 5a22ffdccef3266f6a4050f715f304c10c259ba3 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@no-reply.pragmatique.xyz>
> Date: Sat, 6 May 2017 00:12:58 +0000
> Subject: [PATCH] gnu: fish: Reference 'groff' to fix output of 'fish --help'.
>
> * gnu/packages/shells.scm (fish)[native-inputs]: Add 'groff'.
> (arguments): Add 'nroff' substitution in 'embed-store-paths' phase.

Applied, but moving groff to ‘inputs’ since it’s needed at run time.

Thanks!

Ludo’.