From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4v6c-0006zM-2V for guix-patches@gnu.org; Sun, 30 Apr 2017 16:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4v6Y-0000k8-R0 for guix-patches@gnu.org; Sun, 30 Apr 2017 16:06:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49909) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4v6Y-0000jI-FF for guix-patches@gnu.org; Sun, 30 Apr 2017 16:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d4v6Y-0001jZ-2L for guix-patches@gnu.org; Sun, 30 Apr 2017 16:06:02 -0400 Subject: bug#26718: Update hexchat to 2.12.4 Resent-Message-ID: Date: Sun, 30 Apr 2017 16:05:34 -0400 From: Leo Famulari Message-ID: <20170430200534.GA27383@jasmine> References: <20170430192256.40abec3c@lepiller.eu> <20170430213539.789280bb@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: <20170430213539.789280bb@lepiller.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 26718@debbugs.gnu.org --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Apr 30, 2017 at 09:35:44PM +0200, Julien Lepiller wrote: > What's the policy about using patches, snippet or build phases? I was > recently asked to move code from snippet to build phase because it did > not address a security issue or remove non free or bundled components, > but I can't find anything documenting the choice we should make. I don't know if we have a real "policy"; here are my thoughts. Guix is a useful tool for acquiring free software source code to be used outside of Guix, with `guix build --source`. Origin snippets and patches affect the result of `guix build --source`. Snippets are necessary for removing non-free bits from what is provided by `guix build --source`. Without this, I think we'd run afoul of the free system distribution guidelines (FSDG). Then there are changes we make in order to port software to Guix or make other relatively unimportant changes. If they can be done with a sed-like / regex substitution, we do them in build phases. It's helpful to keep them in Scheme, and we don't want to distribute them via `guix build --source`. Patches are for things that are difficult / opaque to do with a sed-like tool. They are applied to the result of `guix build --source`. I also like using patches when copying changes from upstream; the provenance of the change can be made clear in the patch annotation. For this reason, most of the security updates I push use patches, even if they are one-liners. Maybe these changes aren't always helpful for users of `guix build --source`, but I try to limit them to important bug-fixes. I'm curious to hear others' thoughts on this subject! --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlkGQ44ACgkQJkb6MLrK fwgayRAAiHNdfA3HHH3HjBEAl63TL+SxI8lg9qdQh8mBDpMpnsjQQBZc4F66ULWN MykVX0dqNrvgVPeW9TEUc07LHLdPf/FyYPss3aDg6eya9ykQgcNXSMKMzMmI+Yjr wWUeJ3wL+KtSqYjNFpi3Jv2qRWLBLv6otE67K3RAbJj9bBKnRxEOD0TTPy+UdFgI HbxUktk0S/Th5tIVrCD19TUpBa8OVN4ImnHqOdzBbiqf+Y+hLFi9nfw3jUrtXs03 d0IwfjYnyW+EBKUXIrBS7/J5YUkoj55HRtjRu3oSPmxrTImN4EYaFvhc4GCl+7Zs XvAqeDJepf9ZesoFl6b8qs8xZ5T4oMjkH7b2QMbr9qSW5ePq1KzBc42TptK3sxlS BOI3scgkd1yE351sY1bu1BN2l/GPuMmzJ1Ic5IiSg4fFzP0E/U6LZn61lUWrZu67 NVa0PbA2XMejsj/uqQSl0SlK1SsD+3nz2xOWknj/369pwM1+CpO6U9weXz0YCdlM W90e3/nRh7mL99HBylKFyj26dij98XRwxsZV3mUMzmRH99ZFf92lkQ1gQBAjEj68 mwaPHMW5sxXoLFVUw7WKM5KHrH3UlPlYPegN+OWgKtAyMNDuoNB2K6H90mujqGPK W1m2nNK3bo5lEcfpq/ooCJ99G19VksC97PPCJ2QX4QJkrWOYA1s= =FBwU -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--