bug#26595: lugaru

bug#26595: lugaru

[Julien Lepiller]

[-- Attachment #1: Type: text/plain, Size: 47 bytes --]

Hi,

here is a patch to add a new game, lugaru.

[-- Attachment #2: 0001-gnu-Add-lugaru.patch --]
[-- Type: text/x-patch, Size: 2183 bytes --]

From 8d1230bcccee7ecfe2de7e39198e31e8c076b124 Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Fri, 21 Apr 2017 21:30:03 +0200
Subject: [PATCH] gnu: Add lugaru.

* gnu/packages/games.scm (lugaru): New variable.
---
 gnu/packages/games.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 8ff5958d1..b66988967 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3808,3 +3808,39 @@ utter witty remarks about their surroundings, the various inhabitants of their
 underwater realm quarrel among themselves or comment on the efforts of your
 fish.  The whole game is accompanied by quiet, comforting music.")
     (license license:gpl2+)))
+
+(define-public lugaru
+  (package
+    (name "lugaru")
+    (version "1.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://bitbucket.org/osslugaru/lugaru/downloads/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "15zgcshy22q51rm72zi6y9z7qlgnz5iw3gczjdlir4bqmxy4gspk"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-DSYSTEM_INSTALL=ON")
+       #:tests? #f))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("sdl2" ,sdl2)
+       ("glu" ,glu)
+       ("libjpeg" ,libjpeg-turbo)
+       ("libpng" ,libpng)
+       ("openal" ,openal)
+       ("vorbis" ,libvorbis)
+       ("zlib" ,zlib)))
+    (home-page "https://osslugaru.gitlab.io")
+    (synopsis "Cross-platform third-person action game")
+    (description "The main character, Turner, is an anthropomorphic rebel bunny
+rabbit with impressive combat skills.  In his quest to find those responsible
+for slaughtering his village, he uncovers a far-reaching conspiracy involving
+the corrupt leaders of the rabbit republic and the starving wolves from a
+nearby den.  Turner takes it upon himself to fight against their plot and save
+his fellow rabbits from slavery.")
+    (license (list license:gpl2+ license:cc-by-sa3.0))))
-- 
2.12.2

bug#26595: lugaru

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Julien Lepiller <julien@lepiller.eu> writes:

> Hi,
>
> here is a patch to add a new game, lugaru.

LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#26595: lugaru

[Ricardo Wurmus]

Hi Julien,

thanks for one more game!

> Subject: [PATCH] gnu: Add lugaru.
>
> * gnu/packages/games.scm (lugaru): New variable.
> ---
>  gnu/packages/games.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 8ff5958d1..b66988967 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -3808,3 +3808,39 @@ utter witty remarks about their surroundings, the various inhabitants of their
>  underwater realm quarrel among themselves or comment on the efforts of your
>  fish.  The whole game is accompanied by quiet, comforting music.")
>      (license license:gpl2+)))
> +
> +(define-public lugaru
> +  (package
> +    (name "lugaru")
> +    (version "1.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bitbucket.org/osslugaru/lugaru/downloads/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "15zgcshy22q51rm72zi6y9z7qlgnz5iw3gczjdlir4bqmxy4gspk"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list "-DSYSTEM_INSTALL=ON")
> +       #:tests? #f))

Please add a comment to explain why the tests are disabled.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("glu" ,glu)
> +       ("libjpeg" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("openal" ,openal)
> +       ("vorbis" ,libvorbis)
> +       ("zlib" ,zlib)))
> +    (home-page "https://osslugaru.gitlab.io")
> +    (synopsis "Cross-platform third-person action game")
> +    (description "The main character, Turner, is an anthropomorphic rebel bunny
> +rabbit with impressive combat skills.  In his quest to find those responsible
> +for slaughtering his village, he uncovers a far-reaching conspiracy involving
> +the corrupt leaders of the rabbit republic and the starving wolves from a
> +nearby den.  Turner takes it upon himself to fight against their plot and save
> +his fellow rabbits from slavery.")

It would be good to start the description with a short description that
this is a game.

> +    (license (list license:gpl2+ license:cc-by-sa3.0))))

What does this list mean?  Please add a comment.

Could you please send an updated patch?  It’s good to push with these
changes.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

bug#26595: lugaru

[Julien Lepiller]

[-- Attachment #1: Type: text/plain, Size: 29 bytes --]

Hi, here is an updated patch.

[-- Attachment #2: 0001-gnu-Add-lugaru.patch --]
[-- Type: text/x-patch, Size: 2057 bytes --]

From bece8280bf6216e73a6625648ffe2f67bad40d30 Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Fri, 21 Apr 2017 21:30:03 +0200
Subject: [PATCH] gnu: Add lugaru.

* gnu/packages/games.scm (lugaru): New variable.
---
 gnu/packages/games.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index b31bb93db..1e694d3c7 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3941,3 +3941,39 @@ fabulous Orb of Zot.")
                    license:expat
                    license:zlib
                    license:asl2.0))))
+
+(define-public lugaru
+  (package
+    (name "lugaru")
+    (version "1.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://bitbucket.org/osslugaru/lugaru/downloads/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "15zgcshy22q51rm72zi6y9z7qlgnz5iw3gczjdlir4bqmxy4gspk"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-DSYSTEM_INSTALL=ON")
+       #:tests? #f))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("sdl2" ,sdl2)
+       ("glu" ,glu)
+       ("libjpeg" ,libjpeg-turbo)
+       ("libpng" ,libpng)
+       ("openal" ,openal)
+       ("vorbis" ,libvorbis)
+       ("zlib" ,zlib)))
+    (home-page "https://osslugaru.gitlab.io")
+    (synopsis "Cross-platform third-person action game")
+    (description "The main character, Turner, is an anthropomorphic rebel bunny
+rabbit with impressive combat skills.  In his quest to find those responsible
+for slaughtering his village, he uncovers a far-reaching conspiracy involving
+the corrupt leaders of the rabbit republic and the starving wolves from a
+nearby den.  Turner takes it upon himself to fight against their plot and save
+his fellow rabbits from slavery.")
+    (license (list license:gpl2+ license:cc-by-sa3.0))))
-- 
2.12.2

bug#26595: lugaru

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]

Julien Lepiller <julien@lepiller.eu> writes:

> * gnu/packages/games.scm (lugaru): New variable.

[...]

> +    (arguments
> +     `(#:configure-flags
> +       (list "-DSYSTEM_INSTALL=ON")
> +       #:tests? #f))

Please specify whether there are no tests, or they need something not
available in the build environment, missing dependencies etc.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("glu" ,glu)
> +       ("libjpeg" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("openal" ,openal)
> +       ("vorbis" ,libvorbis)
> +       ("zlib" ,zlib)))
> +    (home-page "https://osslugaru.gitlab.io")
> +    (synopsis "Cross-platform third-person action game")
> +    (description "The main character, Turner, is an anthropomorphic rebel bunny
> +rabbit with impressive combat skills.  In his quest to find those responsible
> +for slaughtering his village, he uncovers a far-reaching conspiracy involving
> +the corrupt leaders of the rabbit republic and the starving wolves from a
> +nearby den.  Turner takes it upon himself to fight against their plot and save
> +his fellow rabbits from slavery.")
> +    (license (list license:gpl2+ license:cc-by-sa3.0))))

We usually add comments about what is covered by which license as well.
In this case it's a safe guess that assets are CC-BY-SA, but it's nice
to have it explicit regardless. Other than that looks good!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#26595: lugaru

[Julien Lepiller]

[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

Le Sun, 30 Apr 2017 16:04:10 +0200,
Marius Bakke <mbakke@fastmail.com> a écrit :

> Julien Lepiller <julien@lepiller.eu> writes:
> 
> > * gnu/packages/games.scm (lugaru): New variable.  
> 
> [...]
> 
> > +    (arguments
> > +     `(#:configure-flags
> > +       (list "-DSYSTEM_INSTALL=ON")
> > +       #:tests? #f))  
> 
> Please specify whether there are no tests, or they need something not
> available in the build environment, missing dependencies etc.
> 
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("sdl2" ,sdl2)
> > +       ("glu" ,glu)
> > +       ("libjpeg" ,libjpeg-turbo)
> > +       ("libpng" ,libpng)
> > +       ("openal" ,openal)
> > +       ("vorbis" ,libvorbis)
> > +       ("zlib" ,zlib)))
> > +    (home-page "https://osslugaru.gitlab.io")
> > +    (synopsis "Cross-platform third-person action game")
> > +    (description "The main character, Turner, is an
> > anthropomorphic rebel bunny +rabbit with impressive combat skills.
> > In his quest to find those responsible +for slaughtering his
> > village, he uncovers a far-reaching conspiracy involving +the
> > corrupt leaders of the rabbit republic and the starving wolves from
> > a +nearby den.  Turner takes it upon himself to fight against their
> > plot and save +his fellow rabbits from slavery.")
> > +    (license (list license:gpl2+ license:cc-by-sa3.0))))  
> 
> We usually add comments about what is covered by which license as
> well. In this case it's a safe guess that assets are CC-BY-SA, but
> it's nice to have it explicit regardless. Other than that looks good!

Arg, I sent the old patch. Here is the new one.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-lugaru.patch --]
[-- Type: text/x-patch, Size: 2284 bytes --]

From caccc34b4c118e5c7edfa92bbf4b08a7c7a7af87 Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Fri, 21 Apr 2017 21:30:03 +0200
Subject: [PATCH] gnu: Add lugaru.

* gnu/packages/games.scm (lugaru): New variable.
---
 gnu/packages/games.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index b31bb93db..9d554af41 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3941,3 +3941,43 @@ fabulous Orb of Zot.")
                    license:expat
                    license:zlib
                    license:asl2.0))))
+
+(define-public lugaru
+  (package
+    (name "lugaru")
+    (version "1.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://bitbucket.org/osslugaru/lugaru/downloads/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "15zgcshy22q51rm72zi6y9z7qlgnz5iw3gczjdlir4bqmxy4gspk"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-DSYSTEM_INSTALL=ON")
+       ;; no test target
+       #:tests? #f))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("sdl2" ,sdl2)
+       ("glu" ,glu)
+       ("libjpeg" ,libjpeg-turbo)
+       ("libpng" ,libpng)
+       ("openal" ,openal)
+       ("vorbis" ,libvorbis)
+       ("zlib" ,zlib)))
+    (home-page "https://osslugaru.gitlab.io")
+    (synopsis "Cross-platform third-person action game")
+    (description "Lugaru is a third-person action game.  The main character,
+Turner, is an anthropomorphic rebel bunny rabbit with impressive combat skills.
+In his quest to find those responsible for slaughtering his village, he uncovers
+a far-reaching conspiracy involving the corrupt leaders of the rabbit republic
+and the starving wolves from a nearby den.  Turner takes it upon himself to
+fight against their plot and save his fellow rabbits from slavery.")
+    (license (list license:gpl2+ ; code
+                   ;; assets:
+                   license:cc-by-sa3.0
+                   license:cc-by-sa4.0))))
-- 
2.12.2

bug#26595: lugaru

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

Julien Lepiller <julien@lepiller.eu> writes:

> Le Sun, 30 Apr 2017 16:04:10 +0200,
> Marius Bakke <mbakke@fastmail.com> a écrit :
>
>> Julien Lepiller <julien@lepiller.eu> writes:
>> 
>> > * gnu/packages/games.scm (lugaru): New variable.  
>> 
>> [...]
>> 
>> > +    (arguments
>> > +     `(#:configure-flags
>> > +       (list "-DSYSTEM_INSTALL=ON")
>> > +       #:tests? #f))  
>> 
>> Please specify whether there are no tests, or they need something not
>> available in the build environment, missing dependencies etc.
>> 
>> > +    (native-inputs
>> > +     `(("pkg-config" ,pkg-config)))
>> > +    (inputs
>> > +     `(("sdl2" ,sdl2)
>> > +       ("glu" ,glu)
>> > +       ("libjpeg" ,libjpeg-turbo)
>> > +       ("libpng" ,libpng)
>> > +       ("openal" ,openal)
>> > +       ("vorbis" ,libvorbis)
>> > +       ("zlib" ,zlib)))
>> > +    (home-page "https://osslugaru.gitlab.io")
>> > +    (synopsis "Cross-platform third-person action game")
>> > +    (description "The main character, Turner, is an
>> > anthropomorphic rebel bunny +rabbit with impressive combat skills.
>> > In his quest to find those responsible +for slaughtering his
>> > village, he uncovers a far-reaching conspiracy involving +the
>> > corrupt leaders of the rabbit republic and the starving wolves from
>> > a +nearby den.  Turner takes it upon himself to fight against their
>> > plot and save +his fellow rabbits from slavery.")
>> > +    (license (list license:gpl2+ license:cc-by-sa3.0))))  
>> 
>> We usually add comments about what is covered by which license as
>> well. In this case it's a safe guess that assets are CC-BY-SA, but
>> it's nice to have it explicit regardless. Other than that looks good!
>
> Arg, I sent the old patch. Here is the new one.

D'oh. Looks good! :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#26595: (no subject)

[Julien Lepiller]