From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d3QXv-0004Dn-In
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:16:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d3QXq-0001jT-Kj
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:16:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43729)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d3QXq-0001jN-AV
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:16:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d3QXq-0001Lx-2L
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:16:02 -0400
Subject: bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools.
Resent-Message-ID: <handler.26669.B26669.14932269535185@debbugs.gnu.org>
Date: Wed, 26 Apr 2017 19:15:49 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170426191549.6774bd32@scratchpost.org>
In-Reply-To: <20170426163038.23515-1-thomas.danckaert@gmail.com>
References: <20170426.180534.1677459693482729603.post@thomasdanckaert.be>
	<20170426163038.23515-1-thomas.danckaert@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Thomas Danckaert <thomas.danckaert@gmail.com>
Cc: Thomas Danckaert <post@thomasdanckaert.be>, 26669@debbugs.gnu.org

On Wed, 26 Apr 2017 18:30:33 +0200
Thomas Danckaert <thomas.danckaert@gmail.com> wrote:

> +           (lambda*  (#:key inputs #:allow-other-keys)
> +             ;; We use sed --in-place because substitute* cannot handle the
> +             ;; character encoding used by growisofs.c.
> +             (system* "sed" "-i" "-e"
> +                      (string-append
> +                       "s,\"mkisofs\","
> +                       "\"" (assoc-ref inputs "cdrtools") "/bin/mkisofs\",")
> +                      "growisofs.c")
> +             #t)))))

Maybe rather use

  (zero? (system* ...))

instead of

  (system* ...)
  #t

Otherwise LGTM!