Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]

On Mon, Apr 24, 2017 at 08:54:41PM +0200, Petter wrote:
> Hei Marius,
> 
> > > +    (native-inputs
> > > +     `(("intltool" ,intltool)
> > > +       ("pkg-config" ,pkg-config)))
> > > +    (propagated-inputs
> > > +     `(("glib:bin" ,glib "bin")))  
> > 
> > Do you know why glib:bin needs to be propagated here? Looking at
> > gnome.scm, it's usually a "native-input". If this program requires
> > some of the executables from that package at runtime, it's better to
> > patch it with the absolute paths.
> 
> I don't know. I just saw it done like this in another package in
> xfce.scm.
> 
> Reading up on inputs I see propagated-inputs "will be installed
> alongside the package they belong to". Yeah, let's see if we can avoid
> that.
> 
> I've adjusted the recipe to test with glib:bin as a native-input,
> it builds fine, and a quick remove and install shows no issues either.
> However, the notification system still worked with it removed, so I'm
> not certain the new one is the one used. I will test this further next
> time I boot my system.
> 
> > Other than that looks great! I'd add an @code{...} wrapper around
> > "org.freedesktop.Notifications" in the description, but that can be
> > fixed up before committing, no need for a new patch.
> 
> I'll make sure to add this if I produce a new patch.
> 
> Thanks for the feedback!
> 
> Best,
> Petter

The collection of inputs makes me wonder if it should be glib-or-gtk
build-system and not "just" gnu-build-system. I don't have a good way to
test if its necessary, but I'd look around.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]