Le Sat, 22 Apr 2017 20:33:21 -0400,
Leo Famulari <leo@famulari.name> a écrit :

> On Sat, Apr 22, 2017 at 11:13:14PM +0200, Julien Lepiller wrote:
> 
> Thanks for all these patches!
> 
> > here are patches that add pootle, a translation server written in
> > django. Some patches modify packages that have several dependents,
> > so it should probably go to core-updates first.  
> 
> We don't want to update foo and break foo's dependents on the master
> branch, but unless foo has > 1200 dependents, we can avoid waiting for
> core-updates. See:
> 
> https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html
> 
> For this patch series, the bigger changes are updates to pytest-runner
> and dateutil, right? That's less than 200 dependent packages. At that
> scale, all the packages could be built as a test on a developer's
> machine, or you could just check a few dependent packages and push it
> to master with fingers crossed ;)
> 
> Patch-specific comments below. Whatever I don't comment on LGTM.
> 
> > Subject: [PATCH 01/34] gnu: python-pytest-runner: Update to 2.11.1.
> > 
> > * gnu/packages/python.scm (python-pytest-runner)
> > (python2-pytest-runner): Update to 2.11.1.  
> 
> I'd check a handful of dependent packages and cross my fingers :)
I've rebuilt everything, and nothing new fails.

> 
> [lots of suggestions]
OK, I applied all your suggestions, thanks :).

I attached the updated patches. I could find how to run some of the
testsuite, and commented when they failed before even running the tests
or when there was no testsuite to begin with. I had to add a few more
packages for the testsuites to run in some packages.

> 
> > Subject: [PATCH 34/34] gnu: Add pootle.
> > 
> > * gnu/packages/django.scm (pootle): New variable.  
> 
> > +    (version "2.8.0rc5")  
> 
> Usually we don't package beta versions or release candidates, but
> sometimes it's the right thing to do. What's the story here?
I use pootle on another system and found that the latest version has
some bugs that make it difficult to use (though not breaking it
completely). I'm a happy user of the release candidate. I could package
version 2.7.6 too, but I wouldn't use it ;).

> 
> [other suggestions]
>

All done too, thanks :)