From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59519)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d21L7-0000ZH-UB
	for guix-patches@gnu.org; Sat, 22 Apr 2017 16:09:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d21L4-00083x-NX
	for guix-patches@gnu.org; Sat, 22 Apr 2017 16:09:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36548)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d21L4-00083p-Jh
	for guix-patches@gnu.org; Sat, 22 Apr 2017 16:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d21L4-0001d4-6u
	for guix-patches@gnu.org; Sat, 22 Apr 2017 16:09:02 -0400
Subject: bug#26544: [PATCH v4 03/10] system: Factorize
	operating-system-boot-parameters-file.
Resent-Message-ID: <handler.26544.B26544.14928916986212@debbugs.gnu.org>
Date: Sat, 22 Apr 2017 22:08:11 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170422220811.52565f42@scratchpost.org>
In-Reply-To: <20170421123714.2395-4-dannym@scratchpost.org>
References: <86h91ikw4m.fsf@gmail.com>
	<20170421123714.2395-1-dannym@scratchpost.org>
	<20170421123714.2395-4-dannym@scratchpost.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 26544@debbugs.gnu.org


On Fri, 21 Apr 2017 14:37:07 +0200
Danny Milosavljevic <dannym@scratchpost.org> wrote:

> +(define (operating-system-boot-parameters os system root-device)

Might make sense to call SYSTEM "SYSTEM.DRV" instead - since it's either a derivation or #f.

> +  "Return a monadic <boot-parameters> record that describes the boot parameters of OS.
> +SYSTEM is optional.  If given, adds kernel arguments for that system to <boot-parameters>."

Might want to elaborate on how SYSTEM is optional (#f stands for "not given").

SYSTEM is not used anywhere in the procedure.  The next patch rectifies that - but I didn't feel like messing up the function signature just to fix it up one patch later.  But even after only patch 03/10 you can give SYSTEM (and patch 03/10 operating-system-boot-parameters-file does that already) - it will just be ignored.