From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czNNy-0003EB-Dv
	for guix-patches@gnu.org; Sat, 15 Apr 2017 09:05:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czNNv-0005Fm-BE
	for guix-patches@gnu.org; Sat, 15 Apr 2017 09:05:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49805)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1czNNv-0005FV-86
	for guix-patches@gnu.org; Sat, 15 Apr 2017 09:05:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czNNu-0006A7-TB
	for guix-patches@gnu.org; Sat, 15 Apr 2017 09:05:02 -0400
Subject: bug#26339: [PATCH 01/18] system: Pass <bootloader-parameter> to grub.
Resent-Message-ID: <handler.26339.B26339.149226148323657@debbugs.gnu.org>
Date: Sat, 15 Apr 2017 15:04:36 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170415150436.46fe66b5@scratchpost.org>
In-Reply-To: <20170402135242.2958-1-m.othacehe@gmail.com>
References: <20170402134916.2871-1-m.othacehe@gmail.com>
	<20170402135242.2958-1-m.othacehe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

Hi,

> +            <boot-parameters>

I think it's disadvantageous to export the entire structure.  It makes the memory layout public and also makes us unable to replace it by a shim easily later - if we ever want to.

> +(define (boot-parameters->menu-entry conf)
> +  (menu-entry
> +   (label (boot-parameters-label conf))
> +   (device (boot-parameters-store-device conf))
> +   (device-mount-point (boot-parameters-store-mount-point conf))
> +   (linux (boot-parameters-kernel conf))
> +   (linux-arguments (boot-parameters-kernel-arguments conf))
> +   (initrd (boot-parameters-initrd conf))))

I think this way of using boot-parameters is good and also doesn't need the <boot-parameters> export above.