all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#26405: [PATCH 0/2] Tweaks to the PHP package.
@ 2017-04-08 15:39 alex.sassmannshausen
  2017-04-08 15:39 ` bug#26403: [PATCH 1/2] gnu: php: Remove '--enable-threads' configure option alex.sassmannshausen
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: alex.sassmannshausen @ 2017-04-08 15:39 UTC (permalink / raw)
  To: 26405; +Cc: Alex Sassmannshausen

From: Alex Sassmannshausen <alex@pompo.co>

The following 2 patches add tweaks to the excellent PHP package.

The first removes --enable-threads.  Its presence causes a warning during the
configure stage of php, because the option is apparently not supported.  I
imagine it was removed with php 7.

The second adds --with-mysqli.  Adding like so makes it default to the mysql
native driver.  Adding this configure option allows running things such as
wordpress, which require mysqli.

Alex Sassmannshausen (2):
  gnu: php: Remove '--enable-threads' configure option.
  gnu: php: Add '--with-mysqli' configure option.

 gnu/packages/php.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.12.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#26403: [PATCH 1/2] gnu: php: Remove '--enable-threads' configure option.
  2017-04-08 15:39 bug#26405: [PATCH 0/2] Tweaks to the PHP package alex.sassmannshausen
@ 2017-04-08 15:39 ` alex.sassmannshausen
  2017-04-08 15:39 ` bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' " alex.sassmannshausen
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: alex.sassmannshausen @ 2017-04-08 15:39 UTC (permalink / raw)
  To: 26403; +Cc: Alex Sassmannshausen

From: Alex Sassmannshausen <alex@pompo.co>

* gnu/packages/php.scm (php): Remove '--enable-threads' configure option, as
  it is no longer recognized in PHP 7.
---
 gnu/packages/php.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 071820ecb..3537a8e97 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -130,8 +130,7 @@
                "--enable-inifile"
                "--enable-mbstring"
                "--enable-pcntl"
-               "--enable-sockets"
-               "--enable-threads"))
+               "--enable-sockets"))
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'do-not-record-build-flags
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' configure option.
  2017-04-08 15:39 bug#26405: [PATCH 0/2] Tweaks to the PHP package alex.sassmannshausen
  2017-04-08 15:39 ` bug#26403: [PATCH 1/2] gnu: php: Remove '--enable-threads' configure option alex.sassmannshausen
@ 2017-04-08 15:39 ` alex.sassmannshausen
  2017-04-11  4:23   ` Leo Famulari
  2017-04-11  4:24 ` bug#26405: [PATCH 0/2] Tweaks to the PHP package Leo Famulari
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: alex.sassmannshausen @ 2017-04-08 15:39 UTC (permalink / raw)
  To: 26404; +Cc: Alex Sassmannshausen

From: Alex Sassmannshausen <alex@pompo.co>

* gnu/packages/php.scm: Add '--with-mysqli' configure option.
---
 gnu/packages/php.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 3537a8e97..4bc301161 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -119,6 +119,7 @@
                ;; extension of php.
                "--with-iconv"
                "--with-openssl"
+               "--with-mysqli"          ; Required for, e.g. wordpress
                "--with-pdo-mysql"
                "--with-zlib"
                "--enable-calendar"
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' configure option.
  2017-04-08 15:39 ` bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' " alex.sassmannshausen
@ 2017-04-11  4:23   ` Leo Famulari
  0 siblings, 0 replies; 8+ messages in thread
From: Leo Famulari @ 2017-04-11  4:23 UTC (permalink / raw)
  To: alex.sassmannshausen; +Cc: Alex Sassmannshausen, 26404

On Sat, Apr 08, 2017 at 05:39:26PM +0200, alex.sassmannshausen@gmail.com wrote:
> From: Alex Sassmannshausen <alex@pompo.co>
> 
> * gnu/packages/php.scm: Add '--with-mysqli' configure option.

LGTM, thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#26405: [PATCH 0/2] Tweaks to the PHP package.
  2017-04-08 15:39 bug#26405: [PATCH 0/2] Tweaks to the PHP package alex.sassmannshausen
  2017-04-08 15:39 ` bug#26403: [PATCH 1/2] gnu: php: Remove '--enable-threads' configure option alex.sassmannshausen
  2017-04-08 15:39 ` bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' " alex.sassmannshausen
@ 2017-04-11  4:24 ` Leo Famulari
  2017-04-11  7:55 ` julien lepiller
       [not found] ` <handler.26405.B.149166601214265.ack@debbugs.gnu.org>
  4 siblings, 0 replies; 8+ messages in thread
From: Leo Famulari @ 2017-04-11  4:24 UTC (permalink / raw)
  To: alex.sassmannshausen; +Cc: Alex Sassmannshausen, 26405

On Sat, Apr 08, 2017 at 05:39:24PM +0200, alex.sassmannshausen@gmail.com wrote:
> From: Alex Sassmannshausen <alex@pompo.co>
> 
> The following 2 patches add tweaks to the excellent PHP package.
> 
> The first removes --enable-threads.  Its presence causes a warning during the
> configure stage of php, because the option is apparently not supported.  I
> imagine it was removed with php 7.

Julien, what do you think?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#26405: [PATCH 0/2] Tweaks to the PHP package.
  2017-04-08 15:39 bug#26405: [PATCH 0/2] Tweaks to the PHP package alex.sassmannshausen
                   ` (2 preceding siblings ...)
  2017-04-11  4:24 ` bug#26405: [PATCH 0/2] Tweaks to the PHP package Leo Famulari
@ 2017-04-11  7:55 ` julien lepiller
  2017-04-21  9:02   ` Ludovic Courtès
       [not found] ` <handler.26405.B.149166601214265.ack@debbugs.gnu.org>
  4 siblings, 1 reply; 8+ messages in thread
From: julien lepiller @ 2017-04-11  7:55 UTC (permalink / raw)
  To: 26405

Thank you for these patches! I tried them, and I think we can push them.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#26405: [PATCH 0/2] Tweaks to the PHP package.
  2017-04-11  7:55 ` julien lepiller
@ 2017-04-21  9:02   ` Ludovic Courtès
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2017-04-21  9:02 UTC (permalink / raw)
  To: julien lepiller, Alex Sassmannshausen; +Cc: 26405

Hello!

julien lepiller <julien@lepiller.eu> skribis:

> Thank you for these patches! I tried them, and I think we can push them.

Alex, if that’s still OK with you, can you push the patches?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#26405: Acknowledgement ([PATCH 0/2] Tweaks to the PHP package.)
       [not found] ` <handler.26405.B.149166601214265.ack@debbugs.gnu.org>
@ 2017-05-13 13:01   ` Alex Sassmannshausen
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Sassmannshausen @ 2017-05-13 13:01 UTC (permalink / raw)
  To: 26405-done


Pushed to master.

GNU bug Tracking System writes:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 26405@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-05-13 13:03 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-08 15:39 bug#26405: [PATCH 0/2] Tweaks to the PHP package alex.sassmannshausen
2017-04-08 15:39 ` bug#26403: [PATCH 1/2] gnu: php: Remove '--enable-threads' configure option alex.sassmannshausen
2017-04-08 15:39 ` bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' " alex.sassmannshausen
2017-04-11  4:23   ` Leo Famulari
2017-04-11  4:24 ` bug#26405: [PATCH 0/2] Tweaks to the PHP package Leo Famulari
2017-04-11  7:55 ` julien lepiller
2017-04-21  9:02   ` Ludovic Courtès
     [not found] ` <handler.26405.B.149166601214265.ack@debbugs.gnu.org>
2017-05-13 13:01   ` bug#26405: Acknowledgement ([PATCH 0/2] Tweaks to the PHP package.) Alex Sassmannshausen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.