From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: 02/02: gnu: certbot: Share python-acme's arguments.
Date: Mon, 10 Apr 2017 15:48:43 -0400
Message-ID: <20170410194843.GD6718@jasmine>
References: <20170408172501.10323.59373@vcs0.savannah.gnu.org>
	<20170408172502.6332922054@vcs0.savannah.gnu.org>
	<87h91xtcxw.fsf@fastmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="WhfpMioaduB5tiZL"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cxfHx-0008LS-B9
	for guix-devel@gnu.org; Mon, 10 Apr 2017 15:47:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cxfHt-0003Ks-Cy
	for guix-devel@gnu.org; Mon, 10 Apr 2017 15:47:49 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54359)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cxfHt-0003Kl-8c
	for guix-devel@gnu.org; Mon, 10 Apr 2017 15:47:45 -0400
Content-Disposition: inline
In-Reply-To: <87h91xtcxw.fsf@fastmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org


--WhfpMioaduB5tiZL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 10, 2017 at 12:48:27AM +0200, Marius Bakke wrote:
> Not to pick on this patch, since this problem was present before..but:
>=20
> "install-file" has an unspecified return value, so I don't think it's
> safe to use in an "and" block. The attached patch should be more
> correct. WDYT?
>=20

> From e3bd8d6df932986c35a2f8088c491eb6f89ee6d5 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Mon, 10 Apr 2017 00:26:45 +0200
> Subject: [PATCH] gnu: certbot, python-acme: Build documentation in separa=
te
>  phase.
>=20
> * gnu/packages/tls.scm (python-acme)[arguments]<:phases>: Add
> 'build-documentation' phase. Rename 'docs' phase to 'install-documentatio=
n'.
> (certbot)[arguments]<:phases>: Adjust accordingly.

LGTM, thanks for being picky :)

--WhfpMioaduB5tiZL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAljr4ZsACgkQJkb6MLrK
fwg9wg//eHkPbKDKtEjj7L98FXaLIiMdAxczyWc8wYIBjdSEOaXh3RiwVVWrpkKx
E/xTcPYojiEmZimB4LwVqJ1nAhSUYYhpz1xw6xgIzQh2i0yry9H0AmOik5NfbvhS
KOa/c2MTCkOyCBxRN08ecIr3IJLKAIiy5eMPUuK7pCETQKJv3jW5sccIdrtjMg5v
i0YFwSwGnbtGaPm3kZ/ll7p+7lb6Y9MOGiDH6sb2O3lRWeemqB0zfIljLayUePih
qDzcOwbKNOFopg+Y10KgeVWdgIfvRL7axvJsEOpFiosX49TUhXFPUd2FOfAGFpBM
+LWPZVZMX5a2e/zaV1k1b7CFViPfZrnntVxxuRIt4rj4DpjYzhot6BFi7BWABIgW
jq499+bSyZsCXWiIwwb5UnsSd5w8zdx+UYacK+Wx0jjp2X6xG/F5StOCuNiNLyIc
/b6z4x9dKbNmD1dlFZb6cOmR3378aRkZopgxK59NDTg3Hn4XwVRmHBLe4a/vnsgh
Jjy+yspcmaw5qtOv715DC5agBrh+WCzLaXfEjlzqbIHEbZInZ48uOaNyb7P85mHY
NMreHCpxp1Rc/lGJWhdiUe72cblS1fGZJkm2CXj3VFYGrI7M+6/rEGBedbNsczTK
peCGOW5Ny/dFsLwcDoTv5ibAGkP4noo7nrhjEt8m4PWA2Pnjh8c=
=zOAD
-----END PGP SIGNATURE-----

--WhfpMioaduB5tiZL--